runtime/observatory/tests/service/process_service_test.dart - Issue 1341733003: Change times reported from io resource meta data to be milliseconds since epoch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/process_service_test.dart

Issue 1341733003: Change times reported from io resource meta data to be milliseconds since epoch (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/file_service_test.dart ('k') | runtime/observatory/tests/service/tcp_socket_service_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/process_service_test.dart

diff --git a/runtime/observatory/tests/service/process_service_test.dart b/runtime/observatory/tests/service/process_service_test.dart

index 2e12732f80ccaa3e6dcffabd63633932ca41c685..5a41d6a6c468e66e43c9874b0b8d2ca0ec953fce 100644

--- a/runtime/observatory/tests/service/process_service_test.dart

+++ b/runtime/observatory/tests/service/process_service_test.dart

@@ -94,6 +94,7 @@ var processTests = [

expect(first['name'], io.Platform.executable);

expect(first['pid'], equals(setup['pids'][0]));

expect(first['arguments'].contains('foobar'), isFalse);

+ expect(first['started_at'], greaterThan(0));

Cutch 2015/09/14 14:23:32 DBC- these field names should be dartCamelCase

ricow1 2015/09/14 15:57:45 haha, I actually tried to be consistent and used u

var second = await isolate.invokeRpcNoUpgrade(

'__getProcessById', { 'id' : all['data'][1]['id'] });

@@ -101,6 +102,8 @@ var processTests = [

expect(second['pid'], equals(setup['pids'][1]));

expect(second['arguments'].contains('foobar'), isTrue);

expect(second['pid'] != first['pid'], isTrue);

+ expect(second['started_at'], greaterThan(0));

+ expect(second['started_at'], greaterThanOrEqualTo(first['started_at']));

var third = await isolate.invokeRpcNoUpgrade(

'__getProcessById', { 'id' : all['data'][2]['id'] });

@@ -108,6 +111,7 @@ var processTests = [

expect(third['pid'], equals(setup['pids'][2]));

expect(third['pid'] != first['pid'], isTrue);

expect(third['pid'] != second['pid'], isTrue);

+ expect(third['started_at'], greaterThanOrEqualTo(second['started_at']));

await isolate.invokeRpcNoUpgrade('__closeStdin', {});

all = await isolate.invokeRpcNoUpgrade('__getProcesses', {});