Issue 134173002: Remove position argument from VTTParser::collectTimeStamp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134173002: Remove position argument from VTTParser::collectTimeStamp (Closed)

Created:
6 years, 11 months ago by fs

Modified:
6 years, 11 months ago

Reviewers:
Mike West, jochen (gone - plz use gerrit)

CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Remove position argument from VTTParser::collectTimeStamp The |position| argument is no longer used by any of the callers. (They all pass a pointer to a dummy local set to zero.) BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164884

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -8 lines)			Patch
M	Source/core/html/track/vtt/VTTCue.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/core/html/track/vtt/VTTParser.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/track/vtt/VTTParser.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/134173002/1

6 years, 11 months ago (2014-01-10 17:13:41 UTC) #3

Message was sent while issue was closed.

Change committed as 164884