Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: Source/core/html/track/vtt/VTTParser.cpp

Issue 134173002: Remove position argument from VTTParser::collectTimeStamp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/vtt/VTTParser.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTParser.cpp
diff --git a/Source/core/html/track/vtt/VTTParser.cpp b/Source/core/html/track/vtt/VTTParser.cpp
index 2414fa9e7adf627f4d94c950e346621887012805..d5e30a3a6528b6e1db5e82c6ce133bd26d41f1aa 100644
--- a/Source/core/html/track/vtt/VTTParser.cpp
+++ b/Source/core/html/track/vtt/VTTParser.cpp
@@ -440,9 +440,9 @@ void VTTParser::createNewRegion(const String& headerValue)
m_regionList.append(region);
}
-bool VTTParser::collectTimeStamp(const String& line, unsigned* position, double& timeStamp)
+bool VTTParser::collectTimeStamp(const String& line, double& timeStamp)
{
- VTTLegacyScanner input(line, position);
+ VTTScanner input(line);
return collectTimeStamp(input, timeStamp);
}
@@ -583,10 +583,9 @@ void VTTTreeBuilder::constructTreeFromToken(Document& document)
break;
}
case VTTTokenTypes::TimestampTag: {
- unsigned position = 0;
String charactersString = m_token.characters();
double parsedTimeStamp;
- if (VTTParser::collectTimeStamp(charactersString, &position, parsedTimeStamp))
+ if (VTTParser::collectTimeStamp(charactersString, parsedTimeStamp))
m_currentNode->parserAppendChild(ProcessingInstruction::create(document, "timestamp", charactersString));
break;
}
« no previous file with comments | « Source/core/html/track/vtt/VTTParser.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698