Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1341563002: Plugin Power Saver: Improve origin handling esp. with OOPIF. (Closed)

Created:
5 years, 3 months ago by tommycli
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Improve origin handling esp. with OOPIF. Patch does a few things: 1) Transitions PPS to use standardized url::Origin rules. Respects unique origins now. 2) Updates PPS code to use replicated origins in out of process iframes. 3) Updates the histogram to be more comprehensive. 4) Updates the browser test to not use Data URLs, which have a unique origin. BUG=530830 Committed: https://crrev.com/58e3172cca992309f1b99f14c0c57c7ebcff0339 Cr-Commit-Position: refs/heads/master@{#348935}

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix one more test. address groby comment #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : fix test #

Patch Set 6 : #

Total comments: 2

Patch Set 7 : address piman comments #

Total comments: 2

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -107 lines) Patch
M chrome/browser/plugins/OWNERS View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 2 3 4 5 6 7 4 chunks +30 lines, -9 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/plugin_content_origin_whitelist.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/plugin_content_origin_whitelist.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_messages.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/renderer/plugin_instance_throttler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/render_frame.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl.cc View 1 2 3 4 5 6 3 chunks +6 lines, -4 lines 0 comments Download
M content/renderer/pepper/plugin_instance_throttler_impl_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper.h View 1 2 3 4 5 chunks +11 lines, -8 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper.cc View 1 2 3 4 7 chunks +13 lines, -27 lines 0 comments Download
M content/renderer/pepper/plugin_power_saver_helper_browsertest.cc View 1 2 3 4 6 chunks +61 lines, -42 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 5 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 5 3 chunks +3 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 40 (13 generated)
tommycli
alexmos, groby: PTAL alexmos: Especially, can you make sure I used the replicated origins for ...
5 years, 3 months ago (2015-09-12 01:16:14 UTC) #2
groby-ooo-7-16
LGTM w/ tiny nit https://codereview.chromium.org/1341563002/diff/1/chrome/browser/plugins/plugin_power_saver_browsertest.cc File chrome/browser/plugins/plugin_power_saver_browsertest.cc (right): https://codereview.chromium.org/1341563002/diff/1/chrome/browser/plugins/plugin_power_saver_browsertest.cc#newcode99 chrome/browser/plugins/plugin_power_saver_browsertest.cc:99: const char* html, Why const ...
5 years, 3 months ago (2015-09-12 01:24:00 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341563002/1
5 years, 3 months ago (2015-09-14 16:58:17 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/96983) mac_chromium_compile_dbg_ng on ...
5 years, 3 months ago (2015-09-14 17:08:51 UTC) #7
alexmos
https://codereview.chromium.org/1341563002/diff/1/content/renderer/pepper/plugin_power_saver_helper.cc File content/renderer/pepper/plugin_power_saver_helper.cc (right): https://codereview.chromium.org/1341563002/diff/1/content/renderer/pepper/plugin_power_saver_helper.cc#newcode147 content/renderer/pepper/plugin_power_saver_helper.cc:147: url::Origin document_origin = main_frame->document().securityOrigin(); You probably want to use ...
5 years, 3 months ago (2015-09-14 17:32:50 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341563002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341563002/60001
5 years, 3 months ago (2015-09-14 18:21:27 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/54159)
5 years, 3 months ago (2015-09-14 18:49:37 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341563002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341563002/80001
5 years, 3 months ago (2015-09-14 19:27:45 UTC) #14
tommycli
groby/alexmos: Thanks, addressed your comments below. I also had to modify another test (that I ...
5 years, 3 months ago (2015-09-14 20:23:56 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 21:18:13 UTC) #17
alexmos
Thanks, LGTM. Please also run the linux_site_isolation trybot to make sure the updated tests work ...
5 years, 3 months ago (2015-09-14 23:22:28 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341563002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341563002/100001
5 years, 3 months ago (2015-09-14 23:38:12 UTC) #20
tommycli
bauerb: chrome/browser/plugins review please piman: content/ review please tsepez: *_messages* review please isherman: tools/ review ...
5 years, 3 months ago (2015-09-14 23:38:27 UTC) #22
Tom Sepez
Messages LGTM
5 years, 3 months ago (2015-09-14 23:44:52 UTC) #23
piman
https://codereview.chromium.org/1341563002/diff/100001/content/renderer/pepper/plugin_instance_throttler_impl.cc File content/renderer/pepper/plugin_instance_throttler_impl.cc (right): https://codereview.chromium.org/1341563002/diff/100001/content/renderer/pepper/plugin_instance_throttler_impl.cc#newcode175 content/renderer/pepper/plugin_instance_throttler_impl.cc:175: frame->GetWebFrame()->view()->mainFrame()->securityOrigin(), Should this be frame->GetWebFrame()->top()->securityOrigin() ?
5 years, 3 months ago (2015-09-14 23:58:23 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341563002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341563002/120001
5 years, 3 months ago (2015-09-15 00:19:08 UTC) #26
tommycli
piman: thanks! https://codereview.chromium.org/1341563002/diff/100001/content/renderer/pepper/plugin_instance_throttler_impl.cc File content/renderer/pepper/plugin_instance_throttler_impl.cc (right): https://codereview.chromium.org/1341563002/diff/100001/content/renderer/pepper/plugin_instance_throttler_impl.cc#newcode175 content/renderer/pepper/plugin_instance_throttler_impl.cc:175: frame->GetWebFrame()->view()->mainFrame()->securityOrigin(), On 2015/09/14 23:58:23, piman (slow to ...
5 years, 3 months ago (2015-09-15 00:38:19 UTC) #27
tommycli
On 2015/09/14 23:44:52, Tom Sepez wrote: > Messages LGTM tsepez: thanks, that was fast!
5 years, 3 months ago (2015-09-15 00:38:37 UTC) #28
piman
LGTM
5 years, 3 months ago (2015-09-15 00:53:57 UTC) #29
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 01:56:50 UTC) #31
Bernhard Bauer
lgtm https://codereview.chromium.org/1341563002/diff/120001/chrome/browser/plugins/plugin_power_saver_browsertest.cc File chrome/browser/plugins/plugin_power_saver_browsertest.cc (right): https://codereview.chromium.org/1341563002/diff/120001/chrome/browser/plugins/plugin_power_saver_browsertest.cc#newcode98 chrome/browser/plugins/plugin_power_saver_browsertest.cc:98: static scoped_ptr<net::test_server::HttpResponse> RespondWithHTML( Static isn't necessary inside of ...
5 years, 3 months ago (2015-09-15 08:16:25 UTC) #32
tommycli
bauerb: thank you! https://codereview.chromium.org/1341563002/diff/120001/chrome/browser/plugins/plugin_power_saver_browsertest.cc File chrome/browser/plugins/plugin_power_saver_browsertest.cc (right): https://codereview.chromium.org/1341563002/diff/120001/chrome/browser/plugins/plugin_power_saver_browsertest.cc#newcode98 chrome/browser/plugins/plugin_power_saver_browsertest.cc:98: static scoped_ptr<net::test_server::HttpResponse> RespondWithHTML( On 2015/09/15 08:16:25, ...
5 years, 3 months ago (2015-09-15 16:02:16 UTC) #33
Ilya Sherman
histograms.xml lgtm
5 years, 3 months ago (2015-09-15 16:53:25 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341563002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341563002/140001
5 years, 3 months ago (2015-09-15 16:53:41 UTC) #37
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 3 months ago (2015-09-15 18:18:35 UTC) #38
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/58e3172cca992309f1b99f14c0c57c7ebcff0339 Cr-Commit-Position: refs/heads/master@{#348935}
5 years, 3 months ago (2015-09-15 18:19:24 UTC) #39
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:47:00 UTC) #40
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/58e3172cca992309f1b99f14c0c57c7ebcff0339
Cr-Commit-Position: refs/heads/master@{#348935}

Powered by Google App Engine
This is Rietveld 408576698