Plugin Power Saver: Improve origin handling esp. with OOPIF.

chrome/browser/plugins/plugin_power_saver_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/ui/zoom/zoom_controller.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/ppapi_test_utils.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
+#include "net/test/embedded_test_server/http_request.h"
+#include "net/test/embedded_test_server/http_response.h"
 #include "ppapi/shared_impl/ppapi_switches.h"
 #include "third_party/WebKit/public/web/WebInputEvent.h"
 #include "ui/base/window_open_disposition.h"
 #include "ui/gfx/geometry/point.h"
 
 namespace {
 
 std::string RunTestScript(base::StringPiece test_script,
                           content::WebContents* contents,
                           const std::string& element_id) {
@@ skipping 58 matching lines @@
       "}"
       "plugin.addEventListener('message', handleEvent);"
       "if (plugin.postMessage !== undefined) {"
       "  plugin.postMessage('getPowerSaverStatus');"
       "}",
       contents, element_id);
   EXPECT_EQ("essential", result);
   EXPECT_TRUE(PluginLoaded(contents, element_id));
 }
 
+static scoped_ptr<net::test_server::HttpResponse> RespondWithHTML(
+    const char* html,

[groby-ooo-7-16, 2015/09/12 01:24:00]

Why const char? (You'll pass on a string ref, you should take a string ref)

[tommycli, 2015/09/14 20:23:56]

Done.

+    const net::test_server::HttpRequest& request) {
+  scoped_ptr<net::test_server::BasicHttpResponse> response(
+      new net::test_server::BasicHttpResponse());
+  response->set_content_type("text/html");
+  response->set_content(html);
+  return response.Pass();
+}
+
 }  // namespace
 
 class PluginPowerSaverBrowserTest : public InProcessBrowserTest {
  public:
+  void SetUpOnMainThread() override {
+    InProcessBrowserTest::SetUpOnMainThread();
+    ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());
+  }
+
   void SetUpCommandLine(base::CommandLine* command_line) override {
     command_line->AppendSwitch(switches::kEnablePluginPowerSaver);
     command_line->AppendSwitch(switches::kEnablePepperTesting);
     command_line->AppendSwitch(switches::kEnablePluginPlaceholderTesting);
     command_line->AppendSwitchASCII(
         switches::kOverridePluginPowerSaverForTesting, "ignore-list");
 
     ASSERT_TRUE(ppapi::RegisterPowerSaverTestPlugin(command_line));
   }
 
  protected:
   void LoadHTML(const char* html) {
-    std::string url_str = "data:text/html;charset=utf-8,";
-    url_str.append(html);
-    ui_test_utils::NavigateToURL(browser(), GURL(url_str));
+    ASSERT_TRUE(embedded_test_server()->Started());
+    embedded_test_server()->RegisterRequestHandler(
+        base::Bind(&RespondWithHTML, html));
+    ui_test_utils::NavigateToURL(browser(), embedded_test_server()->base_url());
     EXPECT_TRUE(content::WaitForRenderFrameReady(
         GetActiveWebContents()->GetMainFrame()));
   }
 
   content::WebContents* GetActiveWebContents() {
     return browser()->tab_strip_model()->GetActiveWebContents();
   }
 
   // This sends a simulated click at |point| and waits for test plugin to send
   // a status message indicating that it is essential. The test plugin sends a
@@ skipping 126 matching lines @@
       "<object id='plugin' data='http://otherorigin.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='400' height='80'></object>");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin");
 
   std::string script = "window.document.getElementById('plugin').height = 400;";
   ASSERT_TRUE(content::ExecuteScript(GetActiveWebContents(), script));
   VerifyPluginMarkedEssential(GetActiveWebContents(), "plugin");
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, BackgroundTabPlugins) {
-  std::string url_str =
-      "data:text/html;charset=utf-8,"
-      "<object id='same_origin' type='application/x-ppapi-tests'></object>"
+  const char html[] =
+      "<object id='same_origin' data='fake.swf' "
+      "    type='application/x-ppapi-tests'></object>"
       "<object id='small_cross_origin' data='http://otherorigin.com/fake1.swf' "
-      "   type='application/x-ppapi-tests' width='400' height='100'></object>";
+      "    type='application/x-ppapi-tests' width='400' height='100'></object>";
+  embedded_test_server()->RegisterRequestHandler(
+      base::Bind(&RespondWithHTML, html));
   ui_test_utils::NavigateToURLWithDisposition(
-      browser(), GURL(url_str), NEW_BACKGROUND_TAB,
+      browser(), embedded_test_server()->base_url(), NEW_BACKGROUND_TAB,
       ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
 
   ASSERT_EQ(2, browser()->tab_strip_model()->count());
   content::WebContents* background_contents =
       browser()->tab_strip_model()->GetWebContentsAt(1);
   EXPECT_TRUE(
       content::WaitForRenderFrameReady(background_contents->GetMainFrame()));
 
   EXPECT_FALSE(PluginLoaded(background_contents, "same_origin"));
   EXPECT_FALSE(PluginLoaded(background_contents, "small_cross_origin"));
 
   browser()->tab_strip_model()->SelectNextTab();
   EXPECT_EQ(background_contents, GetActiveWebContents());
 
   VerifyPluginMarkedEssential(background_contents, "same_origin");
   VerifyPluginIsThrottled(background_contents, "small_cross_origin");
 }
 
 IN_PROC_BROWSER_TEST_F(PluginPowerSaverBrowserTest, ZoomIndependent) {
   ui_zoom::ZoomController::FromWebContents(GetActiveWebContents())
       ->SetZoomLevel(4.0);
   LoadHTML(
       "<object id='plugin' data='http://otherorigin.com/fake.swf' "
       "    type='application/x-ppapi-tests' width='400' height='200'>"
       "</object>");
   VerifyPluginIsThrottled(GetActiveWebContents(), "plugin");
 }