Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1341533005: Avoid scheduling unnecessary ProcessGL between GL draws. (Closed)

Created:
5 years, 3 months ago by hush (inactive)
Modified:
5 years, 3 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org, jbauman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid scheduling unnecessary ProcessGL between GL draws. SurfaceFactory::SubmitCompositorFrame might call glFlush. So calling it during "kModeSync" stage (which does not allow GL) might result in extra kModeProcess. Instead, submit the frame in "kModeDraw" stage to avoid unnecessary kModeProcess. BUG=527113 Committed: https://crrev.com/214d8f9ab144172967bf29e5b12ac5355304c749 Cr-Commit-Position: refs/heads/master@{#348808}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -31 lines) Patch
M android_webview/browser/hardware_renderer.cc View 1 2 3 chunks +39 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
hush (inactive)
PTAL
5 years, 3 months ago (2015-09-14 23:50:28 UTC) #2
boliu
https://codereview.chromium.org/1341533005/diff/20001/android_webview/browser/hardware_renderer.cc File android_webview/browser/hardware_renderer.cc (right): https://codereview.chromium.org/1341533005/diff/20001/android_webview/browser/hardware_renderer.cc#newcode100 android_webview/browser/hardware_renderer.cc:100: if (child_frame_.get() && child_frame_->frame.get()) { Ehh, pass the whole ...
5 years, 3 months ago (2015-09-15 00:02:40 UTC) #3
hush (inactive)
https://codereview.chromium.org/1341533005/diff/20001/android_webview/browser/hardware_renderer.cc File android_webview/browser/hardware_renderer.cc (right): https://codereview.chromium.org/1341533005/diff/20001/android_webview/browser/hardware_renderer.cc#newcode100 android_webview/browser/hardware_renderer.cc:100: if (child_frame_.get() && child_frame_->frame.get()) { On 2015/09/15 00:02:40, boliu ...
5 years, 3 months ago (2015-09-15 00:50:30 UTC) #4
boliu
lgtm
5 years, 3 months ago (2015-09-15 00:57:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341533005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341533005/40001
5 years, 3 months ago (2015-09-15 00:58:43 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-15 01:29:49 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/214d8f9ab144172967bf29e5b12ac5355304c749 Cr-Commit-Position: refs/heads/master@{#348808}
5 years, 3 months ago (2015-09-15 01:30:24 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:41:03 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/214d8f9ab144172967bf29e5b12ac5355304c749
Cr-Commit-Position: refs/heads/master@{#348808}

Powered by Google App Engine
This is Rietveld 408576698