Source/core/css/parser/BisonCSSParser-in.cpp - Issue 134153016: add 'manipulation' support to CSS touch-action parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/BisonCSSParser-in.cpp

Issue 134153016: add 'manipulation' support to CSS touch-action parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSComputedStyleDeclaration.cpp ('K') | « Source/core/css/CSSValueKeywords.in ('k') | Source/core/rendering/style/RenderStyleConstants.h » ('j') | Source/web/tests/data/touch-action-pan.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/parser/BisonCSSParser-in.cpp

diff --git a/Source/core/css/parser/BisonCSSParser-in.cpp b/Source/core/css/parser/BisonCSSParser-in.cpp

index 022c07e1831700fb36d38b0198e9c2a5de3bf986..d3d7341e605d066d2352b4750ba128628607489e 100644

--- a/Source/core/css/parser/BisonCSSParser-in.cpp

+++ b/Source/core/css/parser/BisonCSSParser-in.cpp

@@ -2670,7 +2670,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID propId, bool important)

break;

case CSSPropertyTouchAction:

- // auto | none | [pan-x || pan-y]

+ // auto | none | [pan-x || pan-y] | manipulation

return parseTouchAction(important);

case CSSPropertyAlignSelf:

@@ -8909,7 +8909,7 @@ bool CSSPropertyParser::parseTouchAction(bool important)

CSSParserValue* value = m_valueList->current();

RefPtrWillBeRawPtr<CSSValueList> list = CSSValueList::createSpaceSeparated();

- if (m_valueList->size() == 1 && value && (value->id == CSSValueAuto || value->id == CSSValueNone)) {

+ if (m_valueList->size() == 1 && value && (value->id == CSSValueAuto || value->id == CSSValueNone || value->id == CSSValueManipulation)) {

list->append(cssValuePool().createIdentifierValue(value->id));

addProperty(CSSPropertyTouchAction, list.release(), important);

m_valueList->next();