Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1341143002: Refactor NaCl IRT toolchains, use arm-nacl-clang (Closed)

Created:
5 years, 3 months ago by Roland McGrath
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor NaCl IRT toolchains, use arm-nacl-clang This factors the irt_* toolchain definitions using a template to reduce copied boilerplate. It also switches the ARM build to use arm-nacl-clang rather than arm-nacl-gcc, which matches what the GYP build does now. Many of the compilation flags are still not at all right, but this is enough for the build of the IRT to complete successfully. BUG=531702 R=dpranke@chromium.org Committed: https://crrev.com/916aafa6563eb600b60a683d52d0c121f2eaee92 Cr-Commit-Position: refs/heads/master@{#348781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -71 lines) Patch
M BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +14 lines, -11 lines 0 comments Download
M build/toolchain/nacl/BUILD.gn View 1 chunk +31 lines, -58 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Roland McGrath
5 years, 3 months ago (2015-09-14 21:46:20 UTC) #1
Dirk Pranke
lgtm. this all looks correct.
5 years, 3 months ago (2015-09-14 22:22:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341143002/1
5 years, 3 months ago (2015-09-14 22:24:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 00:06:59 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/916aafa6563eb600b60a683d52d0c121f2eaee92 Cr-Commit-Position: refs/heads/master@{#348781}
5 years, 3 months ago (2015-09-15 00:07:49 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:39:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/916aafa6563eb600b60a683d52d0c121f2eaee92
Cr-Commit-Position: refs/heads/master@{#348781}

Powered by Google App Engine
This is Rietveld 408576698