Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1341103002: [Android] Use large_output=True when getting all properties. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Use large_output=True when getting all properties. The initial caching getprop call fails without an exit code when its output gets truncated. It currently gets reran with large_output=True, but switching it to do so by default will reduce noise. see e.g. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/22248/steps/events_unittests/logs/stdio BUG= Committed: https://crrev.com/a90ba4b756ed5703a94383815c1338852541c483 Cr-Commit-Position: refs/heads/master@{#348722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M build/android/devil/android/device_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/devil/android/device_utils_test.py View 5 chunks +60 lines, -32 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jbudorick
5 years, 3 months ago (2015-09-14 19:43:35 UTC) #2
rnephew (Wrong account)
On 2015/09/14 19:43:35, jbudorick wrote: lgtm
5 years, 3 months ago (2015-09-14 19:46:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341103002/1
5 years, 3 months ago (2015-09-14 20:20:06 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-14 20:20:07 UTC) #7
rnephew (Reviews Here)
On 2015/09/14 20:20:07, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
5 years, 3 months ago (2015-09-14 20:26:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1341103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1341103002/1
5 years, 3 months ago (2015-09-14 20:29:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 21:06:04 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a90ba4b756ed5703a94383815c1338852541c483 Cr-Commit-Position: refs/heads/master@{#348722}
5 years, 3 months ago (2015-09-14 21:06:47 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:37:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a90ba4b756ed5703a94383815c1338852541c483
Cr-Commit-Position: refs/heads/master@{#348722}

Powered by Google App Engine
This is Rietveld 408576698