build/android/devil/android/device_utils.py - Issue 1341103002: [Android] Use large_output=True when getting all properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/device_utils.py

Issue 1341103002: [Android] Use large_output=True when getting all properties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/device_utils.py

diff --git a/build/android/devil/android/device_utils.py b/build/android/devil/android/device_utils.py

index d372b6303380e96247626bec4e1dede3e427f3a2..0b842b6631d67fa1eef297e1d3bf468db7b78057 100644

--- a/build/android/devil/android/device_utils.py

+++ b/build/android/devil/android/device_utils.py

@@ -1653,7 +1653,7 @@ class DeviceUtils(object):

# It takes ~120ms to query a single property, and ~130ms to query all

# properties. So, when caching we always query all properties.

output = self.RunShellCommand(

- ['getprop'], check_return=True,

+ ['getprop'], check_return=True, large_output=True,

timeout=self._default_timeout if timeout is DEFAULT else timeout,

retries=self._default_retries if retries is DEFAULT else retries)

prop_cache.clear()

« no previous file with comments | « no previous file | build/android/devil/android/device_utils_test.py » ('j') | no next file with comments »