chrome/browser/extensions/extension_message_bubble_controller_unittest.cc - Issue 134103002: Refactor the extension message bubbles.

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 134103002: Refactor the extension message bubbles. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/extensions/extension_message_bubble_controller.cc ('k') | chrome/browser/extensions/suspicious_extension_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

diff --git a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

index dbefb7be3567ecb24661f9bcbfe4742d85efc0e4..cf7d4c8da2ca6cb2bd281e915cc1433cb21b54b9 100644

--- a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

+++ b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

@@ -274,6 +274,7 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_WipeoutControllerTest) {

EXPECT_FALSE(prefs->HasWipeoutBeenAcknowledged(extension_id2_));

controller.reset(new TestSuspiciousExtensionBubbleController(

profile()));

+ SuspiciousExtensionBubbleController::ClearProfileListForTesting();

EXPECT_TRUE(controller->ShouldShow());

suspicious_extensions = controller->GetExtensionList();

ASSERT_EQ(1U, suspicious_extensions.size());

@@ -296,6 +297,7 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_WipeoutControllerTest) {

FakeExtensionMessageBubble::BUBBLE_ACTION_CLICK_LINK);

controller.reset(new TestSuspiciousExtensionBubbleController(

profile()));

+ SuspiciousExtensionBubbleController::ClearProfileListForTesting();

EXPECT_TRUE(controller->ShouldShow());

suspicious_extensions = controller->GetExtensionList();

ASSERT_EQ(2U, suspicious_extensions.size());

@@ -351,6 +353,7 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_DevModeControllerTest) {

FakeExtensionMessageBubble::BUBBLE_ACTION_CLICK_ACTION_BUTTON);

controller.reset(new TestDevModeBubbleController(

profile()));

+ DevModeBubbleController::ClearProfileListForTesting();

EXPECT_TRUE(controller->ShouldShow());

dev_mode_extensions = controller->GetExtensionList();

EXPECT_EQ(2U, dev_mode_extensions.size());

@@ -370,6 +373,7 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_DevModeControllerTest) {

FakeExtensionMessageBubble::BUBBLE_ACTION_CLICK_LINK);

controller.reset(new TestDevModeBubbleController(

profile()));

+ DevModeBubbleController::ClearProfileListForTesting();

EXPECT_TRUE(controller->ShouldShow());

dev_mode_extensions = controller->GetExtensionList();

EXPECT_EQ(2U, dev_mode_extensions.size());

@@ -386,6 +390,7 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_DevModeControllerTest) {

controller.reset(new TestDevModeBubbleController(

profile()));

+ DevModeBubbleController::ClearProfileListForTesting();

EXPECT_FALSE(controller->ShouldShow());

dev_mode_extensions = controller->GetExtensionList();

EXPECT_EQ(0U, dev_mode_extensions.size());