Refactor the extension message bubbles.

chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
 #include "chrome/browser/extensions/extension_message_bubble.h"
@@ skipping 256 matching lines @@
   EXPECT_EQ(0U, controller->dismiss_click_count());
 
   // Now disable an extension, specifying the wipeout flag.
   service_->DisableExtension(extension_id1_,
                              Extension::DISABLE_NOT_VERIFIED);
 
   EXPECT_FALSE(prefs->HasWipeoutBeenAcknowledged(extension_id1_));
   EXPECT_FALSE(prefs->HasWipeoutBeenAcknowledged(extension_id2_));
   controller.reset(new TestSuspiciousExtensionBubbleController(
       profile()));
+  SuspiciousExtensionBubbleController::ClearProfileListForTesting();
   EXPECT_TRUE(controller->ShouldShow());
   suspicious_extensions = controller->GetExtensionList();
   ASSERT_EQ(1U, suspicious_extensions.size());
   EXPECT_TRUE(base::ASCIIToUTF16("Extension 1") == suspicious_extensions[0]);
   controller->Show(&bubble);  // Simulate showing the bubble.
   EXPECT_EQ(0U, controller->link_click_count());
   EXPECT_EQ(1U, controller->dismiss_click_count());
   // Now the acknowledge flag should be set only for the first extension.
   EXPECT_TRUE(prefs->HasWipeoutBeenAcknowledged(extension_id1_));
   EXPECT_FALSE(prefs->HasWipeoutBeenAcknowledged(extension_id2_));
   // Clear the flag.
   prefs->SetWipeoutAcknowledged(extension_id1_, false);
   EXPECT_FALSE(prefs->HasWipeoutBeenAcknowledged(extension_id1_));
 
   // Now disable the other extension and exercise the link click code path.
   service_->DisableExtension(extension_id2_,
                              Extension::DISABLE_NOT_VERIFIED);
 
   bubble.set_action_on_show(
       FakeExtensionMessageBubble::BUBBLE_ACTION_CLICK_LINK);
   controller.reset(new TestSuspiciousExtensionBubbleController(
       profile()));
+  SuspiciousExtensionBubbleController::ClearProfileListForTesting();
   EXPECT_TRUE(controller->ShouldShow());
   suspicious_extensions = controller->GetExtensionList();
   ASSERT_EQ(2U, suspicious_extensions.size());
   EXPECT_TRUE(base::ASCIIToUTF16("Extension 1") == suspicious_extensions[1]);
   EXPECT_TRUE(base::ASCIIToUTF16("Extension 2") == suspicious_extensions[0]);
   controller->Show(&bubble);  // Simulate showing the bubble.
   EXPECT_EQ(1U, controller->link_click_count());
   EXPECT_EQ(0U, controller->dismiss_click_count());
   EXPECT_TRUE(prefs->HasWipeoutBeenAcknowledged(extension_id1_));
 }
@@ skipping 35 matching lines @@
   EXPECT_EQ(0U, controller->action_click_count());
   EXPECT_EQ(1U, controller->dismiss_click_count());
   EXPECT_TRUE(service_->GetExtensionById(extension_id1_, false) != NULL);
   EXPECT_TRUE(service_->GetExtensionById(extension_id2_, false) != NULL);
 
   // Do it again, but now press different button (Disable).
   bubble.set_action_on_show(
       FakeExtensionMessageBubble::BUBBLE_ACTION_CLICK_ACTION_BUTTON);
   controller.reset(new TestDevModeBubbleController(
       profile()));
+  DevModeBubbleController::ClearProfileListForTesting();
   EXPECT_TRUE(controller->ShouldShow());
   dev_mode_extensions = controller->GetExtensionList();
   EXPECT_EQ(2U, dev_mode_extensions.size());
   controller->Show(&bubble);  // Simulate showing the bubble.
   EXPECT_EQ(0U, controller->link_click_count());
   EXPECT_EQ(1U, controller->action_click_count());
   EXPECT_EQ(0U, controller->dismiss_click_count());
   EXPECT_TRUE(service_->GetExtensionById(extension_id1_, false) == NULL);
   EXPECT_TRUE(service_->GetExtensionById(extension_id2_, false) == NULL);
 
   // Re-enable the extensions (disabled by the action button above).
   service_->EnableExtension(extension_id1_);
   service_->EnableExtension(extension_id2_);
 
   // Show the dialog a third time, but now press the learn more link.
   bubble.set_action_on_show(
       FakeExtensionMessageBubble::BUBBLE_ACTION_CLICK_LINK);
   controller.reset(new TestDevModeBubbleController(
       profile()));
+  DevModeBubbleController::ClearProfileListForTesting();
   EXPECT_TRUE(controller->ShouldShow());
   dev_mode_extensions = controller->GetExtensionList();
   EXPECT_EQ(2U, dev_mode_extensions.size());
   controller->Show(&bubble);  // Simulate showing the bubble.
   EXPECT_EQ(1U, controller->link_click_count());
   EXPECT_EQ(0U, controller->action_click_count());
   EXPECT_EQ(0U, controller->dismiss_click_count());
   EXPECT_TRUE(service_->GetExtensionById(extension_id1_, false) != NULL);
   EXPECT_TRUE(service_->GetExtensionById(extension_id2_, false) != NULL);
 
   // Now disable the unpacked extension.
   service_->DisableExtension(extension_id1_, Extension::DISABLE_USER_ACTION);
   service_->DisableExtension(extension_id2_, Extension::DISABLE_USER_ACTION);
 
   controller.reset(new TestDevModeBubbleController(
       profile()));
+  DevModeBubbleController::ClearProfileListForTesting();
   EXPECT_FALSE(controller->ShouldShow());
   dev_mode_extensions = controller->GetExtensionList();
   EXPECT_EQ(0U, dev_mode_extensions.size());
 }
 
 }  // namespace extensions