Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Issue 1340693002: Speculative hardening of fullscreen infobar code. (Closed)

Created:
5 years, 3 months ago by Yaron
Modified:
5 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2490
Target Ref:
refs/pending/branch-heads/2490
Project:
chromium
Visibility:
Public.

Description

Speculative hardening of fullscreen infobar code. While this probably isn't the principle infobar crash, it does have a few bad smells: 1) InfoBarDelegate's already have an infobar() accessor. Use that instead of a cached tab instance. 2) Many places in infobar code that handle user events check the context to ensure they're still valid before handling them but this didn't. BUG=481758 TBR=acleung Review URL: https://codereview.chromium.org/1322063003 Cr-Commit-Position: refs/heads/master@{#347017} (cherry picked from commit 4d978263c720d2accbf1ffa35f859bee9f8e3383) Committed: https://chromium.googlesource.com/chromium/src/+/44470c6d4b00c04521dc804bfa8a6f88a09cf1e4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenInfoBarDelegate.java View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/android/fullscreen/fullscreen_infobar_delegate.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Yaron
5 years, 3 months ago (2015-09-11 20:51:22 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
44470c6d4b00c04521dc804bfa8a6f88a09cf1e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698