Chromium Code Reviews

Issue 1322063003: Speculative hardening of fullscreen infobar code. (Closed)

Created:
5 years, 3 months ago by Yaron
Modified:
5 years, 3 months ago
Reviewers:
Changwan Ryu, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative hardening of fullscreen infobar code. While this probably isn't the principle infobar crash, it does have a few bad smells: 1) InfoBarDelegate's already have an infobar() accessor. Use that instead of a cached tab instance. 2) Many places in infobar code that handle user events check the context to ensure they're still valid before handling them but this didn't. BUG=481758 Committed: https://crrev.com/4d978263c720d2accbf1ffa35f859bee9f8e3383 Cr-Commit-Position: refs/heads/master@{#347017}

Patch Set 1 #

Patch Set 2 : don't cache tab #

Unified diffs Side-by-side diffs Stats (+12 lines, -13 lines)
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenInfoBarDelegate.java View 5 chunks +5 lines, -5 lines 0 comments
M chrome/browser/android/fullscreen/fullscreen_infobar_delegate.h View 3 chunks +4 lines, -4 lines 0 comments
M chrome/browser/android/fullscreen/fullscreen_infobar_delegate.cc View 1 chunk +3 lines, -4 lines 0 comments

Messages

Total messages: 7 (2 generated)
Yaron
5 years, 3 months ago (2015-09-02 20:18:02 UTC) #2
gone
lgtm
5 years, 3 months ago (2015-09-02 20:21:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1322063003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1322063003/20001
5 years, 3 months ago (2015-09-02 20:27:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-02 20:55:07 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 20:56:25 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d978263c720d2accbf1ffa35f859bee9f8e3383
Cr-Commit-Position: refs/heads/master@{#347017}

Powered by Google App Engine