Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: ui/base/page_transition_types.cc

Issue 1340683002: Remove base's implicit_cast. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: implicitcast: . Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/page_transition_types.cc
diff --git a/ui/base/page_transition_types.cc b/ui/base/page_transition_types.cc
index 0bd86f613e3a2698145d01225183cd4c6f7b8ec0..31d100f775a9b102a1255251c56aa6b87ecbb5ef 100644
--- a/ui/base/page_transition_types.cc
+++ b/ui/base/page_transition_types.cc
@@ -13,8 +13,8 @@ bool PageTransitionCoreTypeIs(PageTransition lhs,
// Expect the rhs to be a compile time constant without qualifiers.
DCHECK(PageTransitionGetQualifier(rhs) == 0 &&
PageTransitionIsValidType(rhs));
- return implicit_cast<int>(PageTransitionStripQualifier(lhs)) ==
- implicit_cast<int>(PageTransitionStripQualifier(rhs));
+ return static_cast<int>(PageTransitionStripQualifier(lhs)) ==
vmpstr 2015/09/11 21:31:16 This looks like an enum-to-same-enum comparison, s
danakj 2015/09/11 21:33:30 Ya I agree.
+ static_cast<int>(PageTransitionStripQualifier(rhs));
}
PageTransition PageTransitionStripQualifier(PageTransition type) {

Powered by Google App Engine
This is Rietveld 408576698