Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1340653003: Revert of Try changing LockImpl to not have a spin count to see how it affects performance. (Closed)

Created:
5 years, 3 months ago by jam
Modified:
5 years, 2 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Try changing LockImpl to not have a spin count to see how it affects performance. (patchset #1 id:1 of https://codereview.chromium.org/1333053002/ ) Reason for revert: didn't make any difference Original issue's description: > Try changing LockImpl to not have a spin count to see how it affects performance. > > This was last change 7 years ago, and we have grown a lot of usages of locks since then. Since we don't use pthread_spin_lock on posix, I'm curious how this affects performance today on Windows. > > Committed: https://crrev.com/00c9ca679badffc7584439fff00f18cb3977d5da > Cr-Commit-Position: refs/heads/master@{#348280} TBR=cpu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/61f5ad7107405f414b1b14ddff712388ecece98c Cr-Commit-Position: refs/heads/master@{#348417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M base/synchronization/lock_impl_win.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Try changing LockImpl to not have a spin count to see how ...
5 years, 3 months ago (2015-09-11 17:05:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340653003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340653003/1
5 years, 3 months ago (2015-09-11 17:06:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 17:07:09 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/61f5ad7107405f414b1b14ddff712388ecece98c Cr-Commit-Position: refs/heads/master@{#348417}
5 years, 3 months ago (2015-09-11 17:08:00 UTC) #4
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:23:20 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61f5ad7107405f414b1b14ddff712388ecece98c
Cr-Commit-Position: refs/heads/master@{#348417}

Powered by Google App Engine
This is Rietveld 408576698