Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: base/synchronization/lock_impl_win.cc

Issue 1340653003: Revert of Try changing LockImpl to not have a spin count to see how it affects performance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/synchronization/lock_impl.h" 5 #include "base/synchronization/lock_impl.h"
6 6
7 namespace base { 7 namespace base {
8 namespace internal { 8 namespace internal {
9 9
10 LockImpl::LockImpl() { 10 LockImpl::LockImpl() {
11 ::InitializeCriticalSection(&native_handle_); 11 // The second parameter is the spin count, for short-held locks it avoid the
12 // contending thread from going to sleep which helps performance greatly.
13 ::InitializeCriticalSectionAndSpinCount(&native_handle_, 2000);
12 } 14 }
13 15
14 LockImpl::~LockImpl() { 16 LockImpl::~LockImpl() {
15 ::DeleteCriticalSection(&native_handle_); 17 ::DeleteCriticalSection(&native_handle_);
16 } 18 }
17 19
18 bool LockImpl::Try() { 20 bool LockImpl::Try() {
19 if (::TryEnterCriticalSection(&native_handle_) != FALSE) { 21 if (::TryEnterCriticalSection(&native_handle_) != FALSE) {
20 return true; 22 return true;
21 } 23 }
22 return false; 24 return false;
23 } 25 }
24 26
25 void LockImpl::Lock() { 27 void LockImpl::Lock() {
26 ::EnterCriticalSection(&native_handle_); 28 ::EnterCriticalSection(&native_handle_);
27 } 29 }
28 30
29 void LockImpl::Unlock() { 31 void LockImpl::Unlock() {
30 ::LeaveCriticalSection(&native_handle_); 32 ::LeaveCriticalSection(&native_handle_);
31 } 33 }
32 34
33 } // namespace internal 35 } // namespace internal
34 } // namespace base 36 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698