Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 13406004: - Remember objects (not addresses) in the old generation containing new pointers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_test.cc » ('j') | runtime/vm/object.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
===================================================================
--- runtime/vm/assembler_ia32.cc (revision 20732)
+++ runtime/vm/assembler_ia32.cc (working copy)
@@ -1890,6 +1890,7 @@
}
+// Destroys the value register.
void Assembler::StoreIntoObject(Register object,
const Address& dest,
Register value,
@@ -1905,7 +1906,9 @@
}
// A store buffer update is required.
if (value != EAX) pushl(EAX); // Preserve EAX.
- leal(EAX, dest);
+ if (object != EAX) {
+ movl(EAX, object);
+ }
call(&StubCode::UpdateStoreBufferLabel());
if (value != EAX) popl(EAX); // Restore EAX.
Bind(&done);
« no previous file with comments | « no previous file | runtime/vm/assembler_test.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698