Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: runtime/vm/assembler_test.cc

Issue 13406004: - Remember objects (not addresses) in the old generation containing new pointers. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_test.cc
===================================================================
--- runtime/vm/assembler_test.cc (revision 20732)
+++ runtime/vm/assembler_test.cc (working copy)
@@ -31,12 +31,10 @@
EXPECT(old_array.raw() == grow_old_array.data());
EXPECT(!Isolate::Current()->store_buffer_block()->Contains(
- reinterpret_cast<uword>(grow_old_array.raw()) +
- GrowableObjectArray::data_offset() - kHeapObjectTag));
+ reinterpret_cast<uword>(grow_old_array.raw())));
EXPECT(old_array.raw() == grow_new_array.data());
EXPECT(!Isolate::Current()->store_buffer_block()->Contains(
- reinterpret_cast<uword>(grow_new_array.raw()) +
- GrowableObjectArray::data_offset() - kHeapObjectTag));
+ reinterpret_cast<uword>(grow_new_array.raw())));
// Store Smis into the old object.
for (int i = -128; i < 128; i++) {
@@ -44,37 +42,32 @@
test_code(ctx.raw(), smi.raw(), grow_old_array.raw());
EXPECT(reinterpret_cast<RawArray*>(smi.raw()) == grow_old_array.data());
EXPECT(!Isolate::Current()->store_buffer_block()->Contains(
- reinterpret_cast<uword>(grow_old_array.raw()) +
- GrowableObjectArray::data_offset() - kHeapObjectTag));
+ reinterpret_cast<uword>(grow_old_array.raw())));
}
// Store an old object into the old object.
test_code(ctx.raw(), old_array.raw(), grow_old_array.raw());
EXPECT(old_array.raw() == grow_old_array.data());
EXPECT(!Isolate::Current()->store_buffer_block()->Contains(
- reinterpret_cast<uword>(grow_old_array.raw()) +
- GrowableObjectArray::data_offset() - kHeapObjectTag));
+ reinterpret_cast<uword>(grow_old_array.raw())));
// Store a new object into the old object.
test_code(ctx.raw(), new_array.raw(), grow_old_array.raw());
EXPECT(new_array.raw() == grow_old_array.data());
EXPECT(Isolate::Current()->store_buffer_block()->Contains(
- reinterpret_cast<uword>(grow_old_array.raw()) +
- GrowableObjectArray::data_offset() - kHeapObjectTag));
+ reinterpret_cast<uword>(grow_old_array.raw())));
// Store a new object into the new object.
test_code(ctx.raw(), new_array.raw(), grow_new_array.raw());
EXPECT(new_array.raw() == grow_new_array.data());
EXPECT(!Isolate::Current()->store_buffer_block()->Contains(
- reinterpret_cast<uword>(grow_new_array.raw()) +
- GrowableObjectArray::data_offset() - kHeapObjectTag));
+ reinterpret_cast<uword>(grow_new_array.raw())));
// Store an old object into the new object.
test_code(ctx.raw(), old_array.raw(), grow_new_array.raw());
EXPECT(old_array.raw() == grow_new_array.data());
EXPECT(!Isolate::Current()->store_buffer_block()->Contains(
- reinterpret_cast<uword>(grow_new_array.raw()) +
- GrowableObjectArray::data_offset() - kHeapObjectTag));
+ reinterpret_cast<uword>(grow_new_array.raw())));
}
#endif
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | runtime/vm/assembler_x64.cc » ('j') | runtime/vm/object.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698