Chromium Code Reviews Chromium Code Reviews
Issue 1340493002:
Add initial version of chrome://popular-sites-internals page (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@finch_country_version| Index: chrome/browser/resources/popular_sites_internals.html |
| diff --git a/chrome/browser/resources/popular_sites_internals.html b/chrome/browser/resources/popular_sites_internals.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..d07dee22e9f0e7637949a48fc461d5cb4bb1ca2e |
| --- /dev/null |
| +++ b/chrome/browser/resources/popular_sites_internals.html |
| @@ -0,0 +1,60 @@ |
| +<!-- |
| +Copyright 2015 The Chromium Authors. All rights reserved. |
| +Use of this source code is governed by a BSD-style license that can be |
| +found in the LICENSE file. |
| +--> |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| +<meta charset="utf-8"> |
| +<if expr="is_android or is_ios"> |
| +<meta name="viewport" content="width=device-width, initial-scale=1.0, |
| + maximum-scale=1.0, user-scalable=no"> |
| +</if> |
| +<title>Popular Sites Internals</title> |
| +<link rel="stylesheet" href="chrome://resources/css/text_defaults.css"> |
| +<link rel="stylesheet" href="chrome://resources/css/list.css"> |
| +<link rel="stylesheet" href="popular_sites_internals.css"> |
| +<script src="chrome://resources/js/cr.js"></script> |
| +<script src="chrome://resources/js/load_time_data.js"></script> |
| +<script src="chrome://resources/js/util.js"></script> |
| +</head> |
| + |
| +<body> |
| +<div id='info'> |
| + <div class="section" jsskip="true"> |
| + <h2>Download</h2> |
| + <form id="download"> |
|
Bernhard Bauer
2015/09/11 16:00:06
I don't think you even need the <form> if you neve
Marc Treib
2015/09/22 11:13:56
But I do submit it?!
Bernhard Bauer
2015/09/22 13:49:21
Huh. I guess I'm so used to this being done withou
Marc Treib
2015/09/22 14:02:22
Hm yeah, I guess that would be a bit simpler. I ju
Bernhard Bauer
2015/09/22 14:10:23
Hm... a form gives you:
* A convenient way to get
Marc Treib
2015/09/22 14:20:34
Done.
|
| + <table class="section-details"> |
| + <tr> |
| + <td class="detail">Country</td> |
| + <td class="value"><input id="country-input" type="text"></td> |
| + </tr> |
| + <tr> |
| + <td class="detail">Version</td> |
| + <td class="value"><input id="version-input" type="text"></td> |
| + </tr> |
| + <tr> |
| + <td class="detail"><input type="submit" value="Download"></td> |
| + <td id="download-result" class="value"></td> |
| + </tr> |
| + </table> |
| + </form> |
| + </div> |
| + |
| + <div id='sites' class="section"> |
|
Bernhard Bauer
2015/09/11 16:00:06
Use double quotes.
Marc Treib
2015/09/22 11:13:56
Done.
|
| + <h2>Sites</h2> |
| + <table class="section-details"> |
| + <tr jsselect="sites"> |
| + <td class="detail" jscontent="title"></td> |
| + <td class="value" jscontent="url"></td> |
| + </tr> |
| + </table> |
| + </div> |
| +</div> |
| + |
| +<script src="chrome://resources/js/jstemplate_compiled.js"></script> |
|
Bernhard Bauer
2015/09/11 16:00:06
I think you could move these scripts to the head,
Marc Treib
2015/09/22 11:13:56
Done.
|
| +<script src="popular_sites_internals.js"></script> |
| +</body> |
| +</html> |
| + |
