chrome/browser/resources/popular_sites_internals.html - Issue 1340493002: Add initial version of chrome://popular-sites-internals page

Side by Side Diff: chrome/browser/resources/popular_sites_internals.html

Issue 1340493002: Add initial version of chrome://popular-sites-internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@finch_country_version

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/popular_sites_internals.css ('K') | « chrome/browser/resources/popular_sites_internals.css ('k') | chrome/browser/resources/popular_sites_internals.js » ('j') | chrome/browser/ui/webui/popular_sites_internals_ui.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!--

	2 Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6 <!DOCTYPE html>

	7 <html>

	8 <head>

	9 <meta charset="utf-8">

	10 <if expr="is_android or is_ios">

	11 <meta name="viewport" content="width=device-width, initial-scale=1.0,

	12 maximum-scale=1.0, user-scalable=no">

	13 </if>

	14 <title>Popular Sites Internals</title>

	15 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

	16 <link rel="stylesheet" href="chrome://resources/css/list.css">

	17 <link rel="stylesheet" href="popular_sites_internals.css">

	18 <script src="chrome://resources/js/cr.js"></script>

	19 <script src="chrome://resources/js/load_time_data.js"></script>

	20 <script src="chrome://resources/js/util.js"></script>

	21 </head>

	22

	23 <body>

	24 <div id='info'>

	25 <div class="section" jsskip="true">

	26 <h2>Download</h2>

	27 <form id="download">
	Bernhard Bauer 2015/09/11 16:00:06 I don't think you even need the <form> if you neve I don't think you even need the <form> if you never submit it. Marc Treib 2015/09/22 11:13:56 But I do submit it?! Show quoted text On 2015/09/11 16:00:06, Bernhard Bauer wrote: > I don't think you even need the <form> if you never submit it. But I do submit it?! Bernhard Bauer 2015/09/22 13:49:21 Huh. I guess I'm so used to this being done withou Show quoted text On 2015/09/22 11:13:56, Marc Treib wrote: > On 2015/09/11 16:00:06, Bernhard Bauer wrote: > > I don't think you even need the <form> if you never submit it. > > But I do submit it?! Huh. I guess I'm so used to this being done without forms (i.e. by registering a click event on the button instead of submit)... ☺ Marc Treib 2015/09/22 14:02:22 Hm yeah, I guess that would be a bit simpler. I ju Show quoted text On 2015/09/22 13:49:21, Bernhard Bauer wrote: > On 2015/09/22 11:13:56, Marc Treib wrote: > > On 2015/09/11 16:00:06, Bernhard Bauer wrote: > > > I don't think you even need the <form> if you never submit it. > > > > But I do submit it?! > > Huh. I guess I'm so used to this being done without forms (i.e. by registering a > click event on the button instead of submit)... ☺ Hm yeah, I guess that would be a bit simpler. I just copied the form approach from somewhere. Any particular reason to do it one or the other way? Bernhard Bauer 2015/09/22 14:10:23 Hm... a form gives you: * A convenient way to get Show quoted text On 2015/09/22 14:02:22, Marc Treib wrote: > On 2015/09/22 13:49:21, Bernhard Bauer wrote: > > On 2015/09/22 11:13:56, Marc Treib wrote: > > > On 2015/09/11 16:00:06, Bernhard Bauer wrote: > > > > I don't think you even need the <form> if you never submit it. > > > > > > But I do submit it?! > > > > Huh. I guess I'm so used to this being done without forms (i.e. by registering > a > > click event on the button instead of submit)... ☺ > > Hm yeah, I guess that would be a bit simpler. I just copied the form approach > from somewhere. > Any particular reason to do it one or the other way? Hm... a form gives you: * A convenient way to get all the values from its input fields as key-value pairs * The option to send these values to a given URL We don't need either of these, so I think all other things being equal, removing the <form> saves two lines of HTML ☺ Marc Treib 2015/09/22 14:20:34 Done. Show quoted text On 2015/09/22 14:10:23, Bernhard Bauer wrote: > On 2015/09/22 14:02:22, Marc Treib wrote: > > On 2015/09/22 13:49:21, Bernhard Bauer wrote: > > > On 2015/09/22 11:13:56, Marc Treib wrote: > > > > On 2015/09/11 16:00:06, Bernhard Bauer wrote: > > > > > I don't think you even need the <form> if you never submit it. > > > > > > > > But I do submit it?! > > > > > > Huh. I guess I'm so used to this being done without forms (i.e. by > registering > > a > > > click event on the button instead of submit)... ☺ > > > > Hm yeah, I guess that would be a bit simpler. I just copied the form approach > > from somewhere. > > Any particular reason to do it one or the other way? > > Hm... a form gives you: > * A convenient way to get all the values from its input fields as key-value > pairs > * The option to send these values to a given URL > We don't need either of these, so I think all other things being equal, removing > the <form> saves two lines of HTML ☺ Done.
	28 <table class="section-details">

	29 <tr>

	30 <td class="detail">Country</td>

	31 <td class="value"><input id="country-input" type="text"></td>

	32 </tr>

	33 <tr>

	34 <td class="detail">Version</td>

	35 <td class="value"><input id="version-input" type="text"></td>

	36 </tr>

	37 <tr>

	38 <td class="detail"><input type="submit" value="Download"></td>

	39 <td id="download-result" class="value"></td>

	40 </tr>

	41 </table>

	42 </form>

	43 </div>

	44

	45 <div id='sites' class="section">
	Bernhard Bauer 2015/09/11 16:00:06 Use double quotes. Use double quotes. Marc Treib 2015/09/22 11:13:56 Done. Show quoted text On 2015/09/11 16:00:06, Bernhard Bauer wrote: > Use double quotes. Done.
	46 <h2>Sites</h2>

	47 <table class="section-details">

	48 <tr jsselect="sites">

	49 <td class="detail" jscontent="title"></td>

	50 <td class="value" jscontent="url"></td>

	51 </tr>

	52 </table>

	53 </div>

	54 </div>

	55

	56 <script src="chrome://resources/js/jstemplate_compiled.js"></script>
	Bernhard Bauer 2015/09/11 16:00:06 I think you could move these scripts to the head, I think you could move these scripts to the head, as they will only run once the DOM has loaded anyway. Marc Treib 2015/09/22 11:13:56 Done. Show quoted text On 2015/09/11 16:00:06, Bernhard Bauer wrote: > I think you could move these scripts to the head, as they will only run once the > DOM has loaded anyway. Done.
	57 <script src="popular_sites_internals.js"></script>

	58 </body>

	59 </html>

	60

OLD	NEW