chrome/browser/android/popular_sites.cc - Issue 1340493002: Add initial version of chrome://popular-sites-internals page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/popular_sites.cc

Issue 1340493002: Add initial version of chrome://popular-sites-internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@finch_country_version

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/popular_sites.h ('K') | « chrome/browser/android/popular_sites.h ('k') | chrome/browser/browser_resources.grd » ('j') | chrome/browser/resources/popular_sites_internals.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/popular_sites.cc

diff --git a/chrome/browser/android/popular_sites.cc b/chrome/browser/android/popular_sites.cc

index 26a626890f74d51d2d00df2e81f952fa995ceeb3..3326c94dba0bad8f166a22b59b0eecb2de7538a4 100644

--- a/chrome/browser/android/popular_sites.cc

+++ b/chrome/browser/android/popular_sites.cc

@@ -155,6 +155,7 @@ PopularSites::PopularSites(Profile* profile,

const std::string& override_country,

const std::string& override_version,

const std::string& override_filename,

+ bool force_download,

const FinishedCallback& callback)

: callback_(callback), weak_ptr_factory_(this) {

base::FilePath path = GetPopularSitesPath();

@@ -164,7 +165,7 @@ PopularSites::PopularSites(Profile* profile,

downloader_.reset(new FileDownloader(

GetPopularSitesURL(

profile, override_country, override_version, override_filename),

- path, overwrite, profile->GetRequestContext(),

+ path, overwrite || force_download, profile->GetRequestContext(),

base::Bind(&PopularSites::OnDownloadDone, base::Unretained(this), path)));

overwrite = false;

}