Add initial version of chrome://popular-sites-internals page

chrome/browser/android/popular_sites.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/popular_sites.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
@@ skipping 137 matching lines @@
       url(url),
       favicon_url(favicon_url),
       thumbnail_url(thumbnail_url) {}
 
 PopularSites::Site::~Site() {}
 
 PopularSites::PopularSites(Profile* profile,
                            const std::string& override_country,
                            const std::string& override_version,
                            const std::string& override_filename,
+                           bool force_download,
                            const FinishedCallback& callback)
     : callback_(callback), weak_ptr_factory_(this) {
   base::FilePath path = GetPopularSitesPath();
   // Re-download the file once on every Chrome startup, but use the cached
   // local file afterwards.
   static bool overwrite = true;

[Bernhard Bauer, 2015/09/11 16:00:05]

Given that this does now not directly control anymore whether the file will be
overwritten, would it make sense to rename it to something like |first_time|?

[Marc Treib, 2015/09/22 11:13:56]

Done.

   downloader_.reset(new FileDownloader(
       GetPopularSitesURL(
           profile, override_country, override_version, override_filename),
-      path, overwrite, profile->GetRequestContext(),
+      path, overwrite || force_download, profile->GetRequestContext(),
       base::Bind(&PopularSites::OnDownloadDone, base::Unretained(this), path)));
   overwrite = false;
 }
 
 PopularSites::~PopularSites() {}
 
 void PopularSites::OnDownloadDone(const base::FilePath& path, bool success) {
   if (success) {
     base::PostTaskAndReplyWithResult(
         BrowserThread::GetBlockingPool()->GetTaskRunnerWithShutdownBehavior(
@@ skipping 10 matching lines @@
   downloader_.reset();
 }
 
 void PopularSites::OnJsonParsed(scoped_ptr<std::vector<Site>> sites) {
   if (sites)
     sites_.swap(*sites);
   else
     sites_.clear();
   callback_.Run(!!sites);
 }