Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340483002: unbreak no-webrtc builds (Closed)

Created:
5 years, 3 months ago by Mostyn Bramley-Moore
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

unbreak no-webrtc builds https://codereview.chromium.org/1330873002 broke builds with webrtc disabled. BUG=262211 Committed: https://crrev.com/0a64d1ebd0d922b2623244ea27e74bdc536833a8 Cr-Commit-Position: refs/heads/master@{#348435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340483002/1
5 years, 3 months ago (2015-09-11 08:09:19 UTC) #2
Mostyn Bramley-Moore
@Avi, mcasas: please take a look at this tiny ifdef fixup for builds with webrtc ...
5 years, 3 months ago (2015-09-11 08:11:00 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-11 09:02:56 UTC) #6
mcasas
lgtm
5 years, 3 months ago (2015-09-11 16:08:28 UTC) #7
Avi (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-11 18:03:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340483002/1
5 years, 3 months ago (2015-09-11 18:05:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 18:12:15 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0a64d1ebd0d922b2623244ea27e74bdc536833a8 Cr-Commit-Position: refs/heads/master@{#348435}
5 years, 3 months ago (2015-09-11 18:12:55 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:24:11 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0a64d1ebd0d922b2623244ea27e74bdc536833a8
Cr-Commit-Position: refs/heads/master@{#348435}

Powered by Google App Engine
This is Rietveld 408576698