MediaRecorderHandler: connecting Blink factory method to content/

MediaRecorderHandler: connecting Blink factory method to content/

MediaRecorderHandler changes to implementing WebMediaRecorderHandler;

content/ overrides Blink's createMediaRecorderHandler().

context: MediaRecorderHandler is the Blink-orchestrated class
implementing MediaStream Recorder API (see below). It plugs
together an existing MediaStreamVideoTrack to a new
VideoTrackRecorder-WebmMuxer pair. When MSVTrack passes
frames, these get encoded, muxed, and the result is sent to
Blink. See DD @ https://goo.gl/vSjzC5 (*) for the plan. The
previous CL http://crrev.com/1313603004 landed
MediaRecorderHandler, this one allows for its activation.

(*) Used to be https://goo.gl/kreaQj

Depends on https://crrev.com/1319473016 to disable
Blink tests, that after landing-rolling, should be updated and
reenabled.

BUG=262211
Committed: https://crrev.com/7aea7157cff1fbf7774e566a5168d7e544834769
Cr-Commit-Position: refs/heads/master@{#348338}

[mcasas, 2015-09-08 23:38:51]

Patchset #1 (id:1) has been deleted

[mcasas, 2015-09-09 23:52:27]

Patchset #1 (id:20001) has been deleted

[mcasas, 2015-09-10 00:27:37]

Patchset #1 (id:40001) has been deleted

[mcasas, 2015-09-10 01:13:41]

Patchset #1 (id:60001) has been deleted

[mcasas, 2015-09-10 01:33:46]

mcasas@chromium.org changed reviewers:
+ miu@chromium.org

[mcasas, 2015-09-10 01:33:46]

miu@ PTAL.

[mcasas, 2015-09-10 01:34:40]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org

[mcasas, 2015-09-10 01:34:40]

avi@: content/renderer/renderer_blink_platform_impl.{cc, h} please

[Avi (use Gerrit), 2015-09-10 01:36:02]

lgtm

[miu, 2015-09-10 02:31:47]

lgtm % one issue (surprised the compiler didn't catch this):

https://codereview.chromium.org/1330873002/diff/80001/content/renderer/media/...
File content/renderer/media/media_recorder_handler.h (right):

https://codereview.chromium.org/1330873002/diff/80001/content/renderer/media/...
content/renderer/media/media_recorder_handler.h:43: ~MediaRecorderHandler();
Please add override keyword for the dtor too.

[mcasas, 2015-09-10 03:52:33]

Patchset #2 (id:100001) has been deleted

[mcasas, 2015-09-10 18:36:37]

Patchset #3 (id:140001) has been deleted

[mcasas, 2015-09-10 18:36:43]

Patchset #3 (id:160001) has been deleted

[mcasas, 2015-09-10 19:08:35]

Patchset #3 (id:180001) has been deleted

[mcasas, 2015-09-10 19:12:57]

Patchset #3 (id:200001) has been deleted

[mcasas, 2015-09-10 19:52:04]

Patchset #3 (id:220001) has been deleted

[mcasas, 2015-09-10 19:52:12]

Patchset #3 (id:240001) has been deleted

[mcasas, 2015-09-11 05:35:24]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2015-09-11 05:35:24]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
miu@chromium.org
Link to the patchset: https://codereview.chromium.org/1330873002/#ps260001
(title: "Forward declaring WebMediaRecorderHandlerClient (ISO including full
header)")

[commit-bot: I haz the power, 2015-09-11 05:35:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1330873002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1330873002/260001

[commit-bot: I haz the power, 2015-09-11 05:40:42]

Committed patchset #3 (id:260001)

[commit-bot: I haz the power, 2015-09-11 05:41:26]

Patchset 3 (id:??) landed as
https://crrev.com/7aea7157cff1fbf7774e566a5168d7e544834769
Cr-Commit-Position: refs/heads/master@{#348338}

[pneubeck (no reviews), 2015-09-11 07:13:00]

On 2015/09/11 05:41:26, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/7aea7157cff1fbf7774e566a5168d7e544834769
> Cr-Commit-Position: refs/heads/master@{#348338}

FYI: This or some related change seems to have broken GN builds with
enable_webrtc=false .

[commit-bot: I haz the power, 2015-09-23 12:19:11]

Patchset 3 (id:??) landed as
https://crrev.com/7aea7157cff1fbf7774e566a5168d7e544834769
Cr-Commit-Position: refs/heads/master@{#348338}