Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: Source/core/page/EventSource.h

Issue 134043004: Update page & frame classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/DOMWindowPagePopup.h ('k') | Source/core/page/Page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/EventSource.h
diff --git a/Source/core/page/EventSource.h b/Source/core/page/EventSource.h
index bb669b524488784db34d99214c9a41ad76f9ce49..bf54cc4bb624fd4a7404d34e1f3aadec787693c4 100644
--- a/Source/core/page/EventSource.h
+++ b/Source/core/page/EventSource.h
@@ -50,7 +50,7 @@ class ResourceResponse;
class TextResourceDecoder;
class ThreadableLoader;
-class EventSource : public RefCounted<EventSource>, public ScriptWrappable, public EventTargetWithInlineData, private ThreadableLoaderClient, public ActiveDOMObject {
+class EventSource FINAL : public RefCounted<EventSource>, public ScriptWrappable, public EventTargetWithInlineData, private ThreadableLoaderClient, public ActiveDOMObject {
WTF_MAKE_FAST_ALLOCATED;
REFCOUNTED_EVENT_TARGET(EventSource);
public:
@@ -89,12 +89,12 @@ public:
private:
EventSource(ExecutionContext*, const KURL&, const Dictionary&);
- virtual void didReceiveResponse(unsigned long, const ResourceResponse&);
- virtual void didReceiveData(const char*, int);
- virtual void didFinishLoading(unsigned long, double);
- virtual void didFail(const ResourceError&);
- virtual void didFailAccessControlCheck(const ResourceError&);
- virtual void didFailRedirectCheck();
+ virtual void didReceiveResponse(unsigned long, const ResourceResponse&) OVERRIDE;
+ virtual void didReceiveData(const char*, int) OVERRIDE;
+ virtual void didFinishLoading(unsigned long, double) OVERRIDE;
+ virtual void didFail(const ResourceError&) OVERRIDE;
+ virtual void didFailAccessControlCheck(const ResourceError&) OVERRIDE;
+ virtual void didFailRedirectCheck() OVERRIDE;
void scheduleInitialConnect();
void connect();
« no previous file with comments | « Source/core/page/DOMWindowPagePopup.h ('k') | Source/core/page/Page.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698