Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340163004: Not correctly initializing VisualBench commandline arguments (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Not correctly initializing VisualBench commandline arguments TBR=mtklein@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/fb33ae15ce4aa874ffb756e9bd67d7f6390de524

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/VisualBench/VisualBench.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340163004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340163004/20001
5 years, 3 months ago (2015-09-18 13:41:30 UTC) #3
mtklein
lgtm
5 years, 3 months ago (2015-09-18 13:45:13 UTC) #5
borenet
On 2015/09/18 13:45:13, mtklein wrote: > lgtm lgtm2
5 years, 3 months ago (2015-09-18 13:46:58 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 13:47:42 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fb33ae15ce4aa874ffb756e9bd67d7f6390de524

Powered by Google App Engine
This is Rietveld 408576698