Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/VisualBench/VisualBench.cpp

Issue 1340163004: Not correctly initializing VisualBench commandline arguments (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: tweaks Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/VisualBench/VisualBench.cpp
diff --git a/tools/VisualBench/VisualBench.cpp b/tools/VisualBench/VisualBench.cpp
index c4b7c2401383db5c21ccc4ff49b1f429633295fe..b8f39f96fa5f0687a06568d36c9d660ddf7fdae9 100644
--- a/tools/VisualBench/VisualBench.cpp
+++ b/tools/VisualBench/VisualBench.cpp
@@ -25,10 +25,11 @@ DEFINE_bool2(fullscreen, f, true, "Run fullscreen.");
DEFINE_bool2(interactive, n, false, "Run in interactive mode.");
VisualBench::VisualBench(void* hwnd, int argc, char** argv)
- : INHERITED(hwnd)
- , fModule(new VisualLightweightBenchModule(this)) {
+ : INHERITED(hwnd) {
SkCommandLineFlags::Parse(argc, argv);
+ // this has to happen after commandline parsing
+ fModule.reset(new VisualLightweightBenchModule(this));
if (FLAGS_interactive) {
fModule.reset(new VisualInteractiveModule(this));
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698