Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: extensions/browser/app_window/app_window_contents.cc

Issue 1340163002: PlzNavigate: fix timing issue in app window creation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation-throttle
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window_contents.cc
diff --git a/extensions/browser/app_window/app_window_contents.cc b/extensions/browser/app_window/app_window_contents.cc
index 181e211dcd736d3fc7a1a61f5842547ac77ee843..9419ab17b8dc4ce225cd9ad60c7cdd33aee8c752 100644
--- a/extensions/browser/app_window/app_window_contents.cc
+++ b/extensions/browser/app_window/app_window_contents.cc
@@ -54,6 +54,7 @@ void AppWindowContentsImpl::LoadContents(int32 creator_process_id) {
<< ") != creator (" << creator_process_id << "). Routing disabled.";
}
+ LOG(ERROR) << "Navigating to " << url_.spec();
nasko 2015/09/16 20:19:36 Is this log intentional?
clamy 2015/09/16 21:32:35 No it's not :). Removed it.
web_contents_->GetController().LoadURL(
url_, content::Referrer(), ui::PAGE_TRANSITION_LINK,
std::string());
@@ -118,6 +119,13 @@ bool AppWindowContentsImpl::OnMessageReceived(const IPC::Message& message) {
return handled;
}
+void AppWindowContentsImpl::AboutToCommitNavigation(
+ content::NavigationHandle* handle) {
+ if (is_window_ready_)
+ return;
+ host_->OnFirstCommit();
+}
+
void AppWindowContentsImpl::UpdateDraggableRegions(
const std::vector<DraggableRegion>& regions) {
host_->UpdateDraggableRegions(regions);

Powered by Google App Engine
This is Rietveld 408576698