PlzNavigate: fix timing issue in app window creation

extensions/browser/app_window/app_window_contents.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/app_window/app_window_contents.h"
 
 #include <string>
 #include <utility>
 
 #include "content/public/browser/browser_context.h"
@@ skipping 36 matching lines @@
   // shouldn't communicate with the background page anyway (e.g. sandboxed).
   if (web_contents_->GetMainFrame()->GetProcess()->GetID() ==
       creator_process_id) {
     SuspendRenderFrameHost(web_contents_->GetMainFrame());
   } else {
     VLOG(1) << "AppWindow created in new process ("
             << web_contents_->GetMainFrame()->GetProcess()->GetID()
             << ") != creator (" << creator_process_id << "). Routing disabled.";
   }
 
+  LOG(ERROR) << "Navigating to " << url_.spec();

[nasko, 2015/09/16 20:19:36]

Is this log intentional?

[clamy, 2015/09/16 21:32:35]

No it's not :). Removed it.

   web_contents_->GetController().LoadURL(
       url_, content::Referrer(), ui::PAGE_TRANSITION_LINK,
       std::string());
 }
 
 void AppWindowContentsImpl::NativeWindowChanged(
     NativeAppWindow* native_app_window) {
   base::ListValue args;
   base::DictionaryValue* dictionary = new base::DictionaryValue();
   args.Append(dictionary);
@@ skipping 44 matching lines @@
 bool AppWindowContentsImpl::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AppWindowContentsImpl, message)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_UpdateDraggableRegions,
                         UpdateDraggableRegions)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
+void AppWindowContentsImpl::AboutToCommitNavigation(
+    content::NavigationHandle* handle) {
+  if (is_window_ready_)
+    return;
+  host_->OnFirstCommit();
+}
+
 void AppWindowContentsImpl::UpdateDraggableRegions(
     const std::vector<DraggableRegion>& regions) {
   host_->UpdateDraggableRegions(regions);
 }
 
 void AppWindowContentsImpl::SuspendRenderFrameHost(
     content::RenderFrameHost* rfh) {
   DCHECK(rfh);
   // Don't bother blocking requests if the renderer side is already good to go.
   if (is_window_ready_)
     return;
   is_blocking_requests_ = true;
   // The ResourceDispatcherHost only accepts RenderViewHost child ids.
   // TODO(devlin): This will need to change for site isolation.
   content::BrowserThread::PostTask(
       content::BrowserThread::IO, FROM_HERE,
       base::Bind(&content::ResourceDispatcherHost::BlockRequestsForRoute,
                  base::Unretained(content::ResourceDispatcherHost::Get()),
                  rfh->GetProcess()->GetID(),
                  rfh->GetRenderViewHost()->GetRoutingID()));
 }
 
 }  // namespace extensions