[OriginChip] Add options for the position of the origin chip.

chrome/common/chrome_switches.cc

Index: chrome/common/chrome_switches.cc
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc
index 859aad1c1e71c89c4861f18b78fc45786a3a03c8..590d5552c48e1497fcd5895e70d2bf4f8ffcb7d0 100644
--- a/chrome/common/chrome_switches.cc
+++ b/chrome/common/chrome_switches.cc
@@ -701,8 +701,17 @@ const char kEnableOfflineAutoReload[]       = "enable-offline-auto-reload";
 const char kEnableOmniboxAutoCompletionForIme[] =
     "enable-omnibox-auto-completion-for-ime";
 
-// Enables the origin chip.
-const char kEnableOriginChip[]              = "enable-origin-chip";
+// Controls which branch of the origin chip experiment is enabled. The first
+// flag (enable-origin-chip) is equivalent to the third

[Greg Billock, 2014/01/10 18:39:00]

Would it be easier to keep just one flag name and have values be
empty = trailing omnibox
"right" = leading omnibox
"menu" = next to menu

[Justin Donnelly, 2014/01/10 20:11:31]

That would be nicer, yes, but this is necessary to support the Finch
configuration we need.  Copied comment from about_flags.cc that explains this.

+// (enable-origin-chip-right-of-location-bar) and exists for backwards
+// compatability with an earlier version of the experiment.
+const char kEnableOriginChip[] = "enable-origin-chip";
+const char kEnableOriginChipLeftOfLocationBar[] =
+    "enable-origin-chip-left-of-location-bar";
+const char kEnableOriginChipRightOfLocationBar[] =
+    "enable-origin-chip-right-of-location-bar";
+const char kEnableOriginChipLeftOfMenu[] =
+    "enable-origin-chip-left-of-menu";
 
 // Enables panels (always on-top docked pop-up windows).
 const char kEnablePanels[]                  = "enable-panels";
@@ -743,11 +752,11 @@ const char kEnableSdch[]                    = "enable-sdch";
 // Controls which branch of the "search button in omnibox" experiment is
 // enabled.
 const char kEnableSearchButtonInOmniboxAlways[] =
-        "enable-search-button-in-omnibox-always";
+    "enable-search-button-in-omnibox-always";
 const char kEnableSearchButtonInOmniboxForStr[] =
-        "enable-search-button-in-omnibox-for-str";
+    "enable-search-button-in-omnibox-for-str";
 const char kEnableSearchButtonInOmniboxForStrOrIip[] =
-        "enable-search-button-in-omnibox-for-str-or-iip";
+    "enable-search-button-in-omnibox-for-str-or-iip";
 
 // Enables support of sticky keys.
 const char kEnableStickyKeys[]              = "enable-sticky-keys";