[OriginChip] Add options for the position of the origin chip.

chrome/common/chrome_switches.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/chrome_switches.h"
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
 
 namespace switches {
@@ skipping 683 matching lines @@
 const char kEnableNpnHttpOnly[]             = "enable-npn-http";
 
 // Enable auto-reload of error pages if offline.
 const char kEnableOfflineAutoReload[]       = "enable-offline-auto-reload";
 
 // Enables omnibox auto-completion when IME is active.  The auto-completion for
 // IME is shown in the same style as the normal(non-IME) auto-completion.
 const char kEnableOmniboxAutoCompletionForIme[] =
     "enable-omnibox-auto-completion-for-ime";
 
-// Enables the origin chip.
-const char kEnableOriginChip[]              = "enable-origin-chip";
+// Controls which branch of the origin chip experiment is enabled. The first
+// flag (enable-origin-chip) is equivalent to the third

[Greg Billock, 2014/01/10 18:39:00]

Would it be easier to keep just one flag name and have values be
empty = trailing omnibox
"right" = leading omnibox
"menu" = next to menu

[Justin Donnelly, 2014/01/10 20:11:31]

That would be nicer, yes, but this is necessary to support the Finch
configuration we need.  Copied comment from about_flags.cc that explains this.

+// (enable-origin-chip-right-of-location-bar) and exists for backwards
+// compatability with an earlier version of the experiment.
+const char kEnableOriginChip[] = "enable-origin-chip";
+const char kEnableOriginChipLeftOfLocationBar[] =
+    "enable-origin-chip-left-of-location-bar";
+const char kEnableOriginChipRightOfLocationBar[] =
+    "enable-origin-chip-right-of-location-bar";
+const char kEnableOriginChipLeftOfMenu[] =
+    "enable-origin-chip-left-of-menu";
 
 // Enables panels (always on-top docked pop-up windows).
 const char kEnablePanels[]                  = "enable-panels";
 
 // Enables showing unregistered printers in print preview
 const char kEnablePrintPreviewRegisterPromos[] =
     "enable-print-preview-register-promos";
 
 // Enables tracking of tasks in profiler for viewing via about:profiler.
 // To predominantly disable tracking (profiling), use the command line switch:
@@ skipping 20 matching lines @@
 
 // Controls the support for SDCH filtering (dictionary based expansion of
 // content). By default SDCH filtering is enabled. To disable SDCH filtering,
 // use "--enable-sdch=0" as command line argument. SDCH is currently only
 // supported server-side for searches on google.com.
 const char kEnableSdch[]                    = "enable-sdch";
 
 // Controls which branch of the "search button in omnibox" experiment is
 // enabled.
 const char kEnableSearchButtonInOmniboxAlways[] =
-        "enable-search-button-in-omnibox-always";
+    "enable-search-button-in-omnibox-always";
 const char kEnableSearchButtonInOmniboxForStr[] =
-        "enable-search-button-in-omnibox-for-str";
+    "enable-search-button-in-omnibox-for-str";
 const char kEnableSearchButtonInOmniboxForStrOrIip[] =
-        "enable-search-button-in-omnibox-for-str-or-iip";
+    "enable-search-button-in-omnibox-for-str-or-iip";
 
 // Enables support of sticky keys.
 const char kEnableStickyKeys[]              = "enable-sticky-keys";
 
 // Enable SPDY/2. This is a temporary testing flag. See
 // http://crbug.com/303957 .
 const char kEnableSpdy2[]                   = "enable-spdy2";
 
 // Enable SPDY/4 alpha 2. This is a temporary testing flag.
 const char kEnableSpdy4a2[]                 = "enable-spdy4a2";
@@ skipping 904 matching lines @@
 
 // -----------------------------------------------------------------------------
 // DO NOT ADD YOUR CRAP TO THE BOTTOM OF THIS FILE.
 //
 // You were going to just dump your switches here, weren't you? Instead, please
 // put them in alphabetical order above, or in order inside the appropriate
 // ifdef at the bottom. The order should match the header.
 // -----------------------------------------------------------------------------
 
 }  // namespace switches