Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: chrome/browser/about_flags.cc

Issue 134013004: [OriginChip] Add options for the position of the origin chip. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 62b4a73e1937bf8c2b44ee41e684126684e6dd5c..9851aaa0e841d9c2f0f08d4fae5ce9d77b1aca6c 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -351,6 +351,19 @@ const Experiment::Choice kSearchButtonInOmniboxChoices[] = {
switches::kEnableSearchButtonInOmniboxAlways, ""}
};
+// See comment above for kSearchButtonInOmniboxChoices. The same reasoning
+// applies here.
+const Experiment::Choice kOriginChipChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChip, ""},
+ { IDS_FLAGS_ORIGIN_CHIP_LEFT_OF_LOCATION_BAR,
+ switches::kEnableOriginChipLeftOfLocationBar, ""},
+ { IDS_FLAGS_ORIGIN_CHIP_RIGHT_OF_LOCATION_BAR,
+ switches::kEnableOriginChipRightOfLocationBar, ""},
+ { IDS_FLAGS_ORIGIN_CHIP_LEFT_OF_MENU,
+ switches::kEnableOriginChipLeftOfMenu, ""}
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -1932,8 +1945,7 @@ const Experiment kExperiments[] = {
IDS_FLAGS_ORIGIN_CHIP_NAME,
IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION,
kOsCrOS | kOsWin,
- ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOriginChip,
- switches::kDisableOriginChip)
+ MULTI_VALUE_TYPE(kOriginChipChoices)
},
{
"search-button-in-omnibox",

Powered by Google App Engine
This is Rietveld 408576698