Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: chrome/browser/about_flags.cc

Issue 134013004: [OriginChip] Add options for the position of the origin chip. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 2e48c0918fb4301cfdf75f77fa45dc168357f0ad..d57a362b8eefeaa3787c13aeda07e27b4293da8f 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -351,6 +351,19 @@ const Experiment::Choice kSearchButtonInOmniboxChoices[] = {
switches::kEnableSearchButtonInOmniboxAlways, ""}
};
+// See comment above for kSearchButtonInOmniboxChoices. The same reasoning
+// applies here.
+const Experiment::Choice kOriginChipChoices[] = {
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
+ { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChip, ""},
+ { IDS_FLAGS_ORIGIN_CHIP_LEADING_LOCATION_BAR,
+ switches::kEnableOriginChipLeadingLocationBar, ""},
+ { IDS_FLAGS_ORIGIN_CHIP_TRAILING_LOCATION_BAR,
+ switches::kEnableOriginChipTrailingLocationBar, ""},
+ { IDS_FLAGS_ORIGIN_CHIP_LEADING_MENU_BUTTON,
+ switches::kEnableOriginChipLeadingMenuButton, ""}
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -1923,8 +1936,7 @@ const Experiment kExperiments[] = {
IDS_FLAGS_ORIGIN_CHIP_NAME,
IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION,
kOsCrOS | kOsWin,
- ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOriginChip,
- switches::kDisableOriginChip)
+ MULTI_VALUE_TYPE(kOriginChipChoices)
},
{
"search-button-in-omnibox",
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698