Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 134013004: [OriginChip] Add options for the position of the origin chip. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, 344 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
345 switches::kDisableSearchButtonInOmnibox, ""}, 345 switches::kDisableSearchButtonInOmnibox, ""},
346 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR, 346 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR,
347 switches::kEnableSearchButtonInOmniboxForStr, ""}, 347 switches::kEnableSearchButtonInOmniboxForStr, ""},
348 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR_OR_IIP, 348 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLE_FOR_STR_OR_IIP,
349 switches::kEnableSearchButtonInOmniboxForStrOrIip, ""}, 349 switches::kEnableSearchButtonInOmniboxForStrOrIip, ""},
350 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED, 350 { IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_ENABLED,
351 switches::kEnableSearchButtonInOmniboxAlways, ""} 351 switches::kEnableSearchButtonInOmniboxAlways, ""}
352 }; 352 };
353 353
354 // See comment above for kSearchButtonInOmniboxChoices. The same reasoning
355 // applies here.
356 const Experiment::Choice kOriginChipChoices[] = {
357 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
358 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOriginChip, ""},
359 { IDS_FLAGS_ORIGIN_CHIP_LEADING_LOCATION_BAR,
360 switches::kEnableOriginChipLeadingLocationBar, ""},
361 { IDS_FLAGS_ORIGIN_CHIP_TRAILING_LOCATION_BAR,
362 switches::kEnableOriginChipTrailingLocationBar, ""},
363 { IDS_FLAGS_ORIGIN_CHIP_LEADING_MENU_BUTTON,
364 switches::kEnableOriginChipLeadingMenuButton, ""}
365 };
366
354 // RECORDING USER METRICS FOR FLAGS: 367 // RECORDING USER METRICS FOR FLAGS:
355 // ----------------------------------------------------------------------------- 368 // -----------------------------------------------------------------------------
356 // The first line of the experiment is the internal name. If you'd like to 369 // The first line of the experiment is the internal name. If you'd like to
357 // gather statistics about the usage of your flag, you should append a marker 370 // gather statistics about the usage of your flag, you should append a marker
358 // comment to the end of the feature name, like so: 371 // comment to the end of the feature name, like so:
359 // "my-special-feature", // FLAGS:RECORD_UMA 372 // "my-special-feature", // FLAGS:RECORD_UMA
360 // 373 //
361 // After doing that, run //tools/metrics/actions/extract_actions.py (see 374 // After doing that, run //tools/metrics/actions/extract_actions.py (see
362 // instructions at the top of that file for details) to update the 375 // instructions at the top of that file for details) to update the
363 // chromeactions.txt file, which will enable UMA to record your feature flag. 376 // chromeactions.txt file, which will enable UMA to record your feature flag.
(...skipping 1552 matching lines...) Expand 10 before | Expand all | Expand 10 after
1916 IDS_FLAGS_NUM_RASTER_THREADS_NAME, 1929 IDS_FLAGS_NUM_RASTER_THREADS_NAME,
1917 IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION, 1930 IDS_FLAGS_NUM_RASTER_THREADS_DESCRIPTION,
1918 kOsAll, 1931 kOsAll,
1919 MULTI_VALUE_TYPE(kNumRasterThreadsChoices) 1932 MULTI_VALUE_TYPE(kNumRasterThreadsChoices)
1920 }, 1933 },
1921 { 1934 {
1922 "origin-chip", 1935 "origin-chip",
1923 IDS_FLAGS_ORIGIN_CHIP_NAME, 1936 IDS_FLAGS_ORIGIN_CHIP_NAME,
1924 IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION, 1937 IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION,
1925 kOsCrOS | kOsWin, 1938 kOsCrOS | kOsWin,
1926 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableOriginChip, 1939 MULTI_VALUE_TYPE(kOriginChipChoices)
1927 switches::kDisableOriginChip)
1928 }, 1940 },
1929 { 1941 {
1930 "search-button-in-omnibox", 1942 "search-button-in-omnibox",
1931 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME, 1943 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME,
1932 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION, 1944 IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_DESCRIPTION,
1933 kOsCrOS | kOsMac | kOsWin, 1945 kOsCrOS | kOsMac | kOsWin,
1934 MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices) 1946 MULTI_VALUE_TYPE(kSearchButtonInOmniboxChoices)
1935 }, 1947 },
1936 { 1948 {
1937 "enable-ignore-autocomplete-off", 1949 "enable-ignore-autocomplete-off",
(...skipping 515 matching lines...) Expand 10 before | Expand all | Expand 10 after
2453 } 2465 }
2454 2466
2455 const Experiment* GetExperiments(size_t* count) { 2467 const Experiment* GetExperiments(size_t* count) {
2456 *count = num_experiments; 2468 *count = num_experiments;
2457 return experiments; 2469 return experiments;
2458 } 2470 }
2459 2471
2460 } // namespace testing 2472 } // namespace testing
2461 2473
2462 } // namespace about_flags 2474 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/search/search.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698