Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.
Issue 134013004: [OriginChip] Add options for the position of the origin chip. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/search/search_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 52620b1d1dea74eb06900ec17254d42452ca3d13..42ec1c98645a437474a099cfca39e520417b84fb 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -6817,6 +6817,15 @@ Keep your key file in a safe place. You will need it to create new versions of y
<message name="IDS_FLAGS_ORIGIN_CHIP_DESCRIPTION" desc="Description of about:flags option to enable the display of the Origin Chip experiment.">
Moves the URL out of the Omnibox and shows the hostname in the origin chip in the toolbar.
</message>
+ <message name="IDS_FLAGS_ORIGIN_CHIP_LEFT_OF_LOCATION_BAR" desc="Option in a drop-down menu to enable the display of the origin chip to the left of the location bar.">
msw 2014/01/10 18:26:04 nit: should all this terminology be changed like s
Justin Donnelly 2014/01/10 20:11:31 Yes, I think you're right. Maybe someday I'll get
+ Enabled and positioned to the left of the location bar
+ </message>
+ <message name="IDS_FLAGS_ORIGIN_CHIP_RIGHT_OF_LOCATION_BAR" desc="Option in a drop-down menu to enable the display of the origin chip to the right of the location bar.">
+ Enabled and positioned to the right of the location bar
+ </message>
+ <message name="IDS_FLAGS_ORIGIN_CHIP_LEFT_OF_MENU" desc="Option in a drop-down menu to enable the display of the origin chip to the left of the menu.">
+ Enabled and positioned to the left of the menu
Greg Billock 2014/01/10 18:39:00 perhaps "app menu button" here?
Justin Donnelly 2014/01/10 20:11:31 Done. Good point, it's sounds more consistent to r
+ </message>
<message name="IDS_FLAGS_SEARCH_BUTTON_IN_OMNIBOX_NAME" desc="Name of about:flags option to enable the search button in omnibox experiment.">
Enable search button in Omnibox
</message>
« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/search/search_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698