Issue 1339963002: Omit save_password_infobar.cc from the build when unused

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1339963002: Omit save_password_infobar.cc from the build when unused (Closed)

Created:
5 years, 3 months ago by tapted

Modified:
5 years, 3 months ago

Reviewers:
ki.stfu

CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Omit save_password_infobar.cc from the build when unused BUG=526837 patch from issue 1313383006 at patchset 80001 (http://crrev.com/1313383006#ps80001)

Patch Set 1 : Baseline from 1313383006 #

Patch Set 2 : Fix mac_views_browser #

Patch Set 3 : gn changes #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -16 lines)			Patch
M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/BUILD.gn	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/password_manager/chrome_password_manager_client.cc	View		6 chunks	+14 lines, -3 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/save_password_infobar.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+10 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/test/BUILD.gn	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

@tapted, thanks!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages