Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7542)

Unified Diff: chrome/chrome_browser.gypi

Issue 1339963002: Omit save_password_infobar.cc from the build when unused (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: gn changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/infobars/save_password_infobar.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index c33ec1de73875c67ee6c0af517eede32e021238e..723d86f9d940be6cf2901fc38cc04f9bca00a8f5 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -2063,11 +2063,14 @@
'browser/password_manager/password_store_win.h',
'browser/password_manager/password_store_x.cc',
'browser/password_manager/password_store_x.h',
- 'browser/password_manager/save_password_infobar_delegate.cc',
- 'browser/password_manager/save_password_infobar_delegate.h',
'browser/password_manager/simple_password_store_mac.cc',
'browser/password_manager/simple_password_store_mac.h',
],
+ # Used on Mac and Android platforms.
+ 'chrome_browser_password_manager_mac_android_sources': [
+ 'browser/password_manager/save_password_infobar_delegate.cc',
+ 'browser/password_manager/save_password_infobar_delegate.h',
+ ],
'chrome_browser_permissions_sources': [
'browser/permissions/permission_bubble_request_impl.cc',
'browser/permissions/permission_bubble_request_impl.h',
@@ -3387,6 +3390,11 @@
],
'sources': [ '<@(chrome_browser_mac_sources)' ]
}],
+ ['OS=="mac" or OS=="android"', {
+ 'sources': [
+ '<@(chrome_browser_password_manager_mac_android_sources)',
+ ],
+ }],
['chromeos==1', {
'sources!': [
'browser/metrics/signin_status_metrics_provider.cc',
« no previous file with comments | « chrome/browser/ui/views/infobars/save_password_infobar.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698