Issue 133993002: Revert "Add debug output to presubmit script for investigating tree check behavior."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133993002: Revert "Add debug output to presubmit script for investigating tree check behavior." (Closed)

Created:
6 years, 11 months ago by Michael Achenbach

Modified:
6 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "Add debug output to presubmit script for investigating tree check behavior." and "Add more temporary debugging output to PRESUBMIT.py". This reverts commits r18538 and r18528, since the investigated problem was found. BUG= TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18544

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -8 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+3 lines, -8 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

6 years, 11 months ago (2014-01-10 16:13:57 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/133993002/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/133993002/diff/1/PRESUBMIT.py#newcode65
PRESUBMIT.py:65: FilterFile = lambda file: file.LocalPath() == src_version
Wanna go the extra mile? Remove this unused definition (or, alternately, use it
instead of its duplicate below).

Expand Messages | Collapse Messages