Chromium Code Reviews| Index: PRESUBMIT.py |
| diff --git a/PRESUBMIT.py b/PRESUBMIT.py |
| index 71907be309d23404e3a5b8dbda6bd682cd2febc5..fe15157dde7f7e237bb85a77725f6e08b89c3714 100644 |
| --- a/PRESUBMIT.py |
| +++ b/PRESUBMIT.py |
| @@ -61,15 +61,11 @@ def _CommonChecks(input_api, output_api): |
| def _SkipTreeCheck(input_api, output_api): |
| """Check the env var whether we want to skip tree check. |
| Only skip if src/version.cc has been updated.""" |
| - print "skip tree check?", input_api.environ.get('PRESUBMIT_TREE_CHECK') |
| src_version = 'src/version.cc' |
| - def FilterFile(file): |
| - print "Changed file:", file.LocalPath() |
| - return file.LocalPath() == src_version |
| - if not input_api.AffectedSourceFiles(FilterFile): |
| + FilterFile = lambda file: file.LocalPath() == src_version |
|
Jakob Kummerow
2014/01/10 16:13:57
Wanna go the extra mile? Remove this unused defini
|
| + if not input_api.AffectedSourceFiles( |
| + lambda file: file.LocalPath() == src_version): |
| return False |
| - if input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip': |
| - print "Skip tree check requested via environment variable." |
| return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip' |
| @@ -98,7 +94,6 @@ def CheckChangeOnCommit(input_api, output_api): |
| results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| input_api, output_api)) |
| if not _SkipTreeCheck(input_api, output_api): |
| - print "Checking if tree is open." |
| results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| input_api, output_api, |
| json_url='http://v8-status.appspot.com/current?format=json')) |