win: Fix ProcessInfo test when running on x86 host OS

util/win/process_info_test.cc

Index: util/win/process_info_test.cc
diff --git a/util/win/process_info_test.cc b/util/win/process_info_test.cc
index 3bc18c723831c4e4c17cfcb7bd36b60095007ad9..76ecb4a603b303bf135b899cd68572a90a45ed1e 100644
--- a/util/win/process_info_test.cc
+++ b/util/win/process_info_test.cc
@@ -16,6 +16,7 @@
 
 #include <imagehlp.h>
 #include <rpc.h>
+#include <stdlib.h>
 #include <wchar.h>
 
 #include "base/files/file_path.h"
@@ -52,8 +53,11 @@ TEST(ProcessInfo, Self) {
   EXPECT_FALSE(process_info.IsWow64());
 #else
   EXPECT_FALSE(process_info.Is64Bit());
-  // Assume we won't be running these tests on a 32 bit host OS.
-  EXPECT_TRUE(process_info.IsWow64());
+  char* processor_architew6432 = getenv("PROCESSOR_ARCHITEW6432");

[Mark Mentovai, 2015/09/11 22:38:56]

I think that using environment variables like this is a little hokey, because
they’re so easy to change and mess up. I’d suggest
IsWow64Process(GetCurrentProcess()), but then I guess you’d just be testing the
same thing that ProcessInfo does. But maybe that’s not so terrible, since it’s
basically up to the system to get this right.

[scottmg, 2015/09/11 23:39:55]

Yeah, that's I tried to verify with "some other" source of data. Maybe it's just
as sensible to delete the EXPECT_ then, rather than duplicate the exact same
code as on the other side?

+  if (processor_architew6432 && std::string(processor_architew6432) == "AMD64")

[Mark Mentovai, 2015/09/11 22:38:56]

Just strcmp() instead of creating a std::string?

+    EXPECT_TRUE(process_info.IsWow64());
+  else
+    EXPECT_FALSE(process_info.IsWow64());
 #endif
 
   std::wstring command_line;