Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1339803003: Move gcm_internals resources and constants to //components. (Closed)

Created:
5 years, 3 months ago by droger
Modified:
5 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org, zea+watch_chromium.org, Dan Beam, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move gcm_internals resources and constants to //components. These are moved in order to be shared on iOS. resource_ids are updated as follows: generated_resources.grd: -100 components_strings.grd : +70 components_chromium_strings.grd: +10 components_resources.grd: +20 Committed: https://crrev.com/e89640c464a7e40c00f9b40852ee88e94fa04101 Cr-Commit-Position: refs/heads/master@{#348949}

Patch Set 1 #

Patch Set 2 : update grit whitelist #

Patch Set 3 : Fix gritsettings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -445 lines) Patch
M build/ios/grit_whitelist.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/gcm_internals.css View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/resources/gcm_internals.html View 1 chunk +0 lines, -174 lines 0 comments Download
D chrome/browser/resources/gcm_internals.js View 1 chunk +0 lines, -148 lines 0 comments Download
M chrome/browser/ui/webui/gcm_internals_ui.cc View 4 chunks +33 lines, -25 lines 0 comments Download
M components/gcm_driver.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/gcm_driver/gcm_internals_constants.h View 1 chunk +43 lines, -0 lines 0 comments Download
A components/gcm_driver/gcm_internals_constants.cc View 1 chunk +37 lines, -0 lines 0 comments Download
A + components/gcm_driver/resources/gcm_internals.css View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/gcm_driver/resources/gcm_internals.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/gcm_driver/resources/gcm_internals.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M components/resources/components_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A components/resources/gcm_driver_resources.grdp View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 2 1 chunk +56 lines, -56 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (7 generated)
droger
zea: for review blundell, dbeam: FYI as an example of WebUI componentization for iOS.
5 years, 3 months ago (2015-09-14 15:23:52 UTC) #2
Dan Beam
Duplicate resource 30310
5 years, 3 months ago (2015-09-14 18:47:27 UTC) #4
Nicolas Zea
gcm changes LGTM once Dan's comment is addressed.
5 years, 3 months ago (2015-09-14 19:44:19 UTC) #5
droger
blundell: can you take a look at components/resources as OWNER, and also resource_ids
5 years, 3 months ago (2015-09-15 10:46:58 UTC) #7
blundell
lgtm
5 years, 3 months ago (2015-09-15 10:53:32 UTC) #8
droger
Thank you all for the reviews.
5 years, 3 months ago (2015-09-15 10:56:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339803003/40001
5 years, 3 months ago (2015-09-15 10:56:33 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99810)
5 years, 3 months ago (2015-09-15 11:05:20 UTC) #14
droger
dbeam: can you do OWNERS review for chrome/browser/resources chrome/browser/ui/webui chrome/browser/generated_resources.grd
5 years, 3 months ago (2015-09-15 12:49:14 UTC) #15
Dan Beam
lgtm, though we should autogenerate tools/gritsettings/resource_ids because it's a unfortunate cluster
5 years, 3 months ago (2015-09-15 18:44:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339803003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339803003/40001
5 years, 3 months ago (2015-09-15 18:46:03 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-15 18:57:53 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e89640c464a7e40c00f9b40852ee88e94fa04101 Cr-Commit-Position: refs/heads/master@{#348949}
5 years, 3 months ago (2015-09-15 18:58:36 UTC) #20
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:47:43 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e89640c464a7e40c00f9b40852ee88e94fa04101
Cr-Commit-Position: refs/heads/master@{#348949}

Powered by Google App Engine
This is Rietveld 408576698