Move sync_internals resources and constants to //components.

Move sync_internals resources and constants to //components.

TBR=jochen
NOPRESUBMIT=true

Committed: https://crrev.com/5144c4343704453671333c412011678602bfa2aa
Cr-Commit-Position: refs/heads/master@{#349395}

[droger, 2015-09-15 16:53:02]

Patchset #1 (id:1) has been deleted

[droger, 2015-09-15 17:40:34]

droger@chromium.org changed reviewers:
+ zea@chromium.org

[Nicolas Zea, 2015-09-15 20:17:48]

https://codereview.chromium.org/1334173006/diff/30001/components/sync_driver/...
File components/sync_driver/about_sync_util.h (right):

https://codereview.chromium.org/1334173006/diff/30001/components/sync_driver/...
components/sync_driver/about_sync_util.h:51: extern const char kCommit[];
I'm a bit hesitant about having these names be so generic and in the sync_driver
namespace. What having a ui_util namespace? Or changing these consts such that
they have a shared prefix/suffix, e.g. kCommitUITag.

[droger, 2015-09-16 08:38:31]

Thanks, please take a look.

https://codereview.chromium.org/1334173006/diff/30001/components/sync_driver/...
File components/sync_driver/about_sync_util.h (right):

https://codereview.chromium.org/1334173006/diff/30001/components/sync_driver/...
components/sync_driver/about_sync_util.h:51: extern const char kCommit[];
On 2015/09/15 20:17:47, Nicolas Zea wrote:
> I'm a bit hesitant about having these names be so generic and in the
sync_driver
> namespace. What having a ui_util namespace? Or changing these consts such that
> they have a shared prefix/suffix, e.g. kCommitUITag.

Sounds good.
Instead of renaming the sync_ui_util namespace to sync_driver, I now nested the
two.

[Nicolas Zea, 2015-09-16 17:49:53]

LGTM, thanks!

[droger, 2015-09-17 08:01:30]

droger@chromium.org changed reviewers:
+ blundell@chromium.org

[droger, 2015-09-17 08:01:31]

+blundell for components

[droger, 2015-09-17 08:02:05]

On 2015/09/17 08:01:31, droger wrote:
> +blundell for components

This is actually only components/resources, components/sync_driver is already
covered.

[blundell, 2015-09-17 10:04:38]

//components/resources lgtm

[droger, 2015-09-17 10:12:31]

droger@chromium.org changed reviewers:
+ jochen@chromium.org

[droger, 2015-09-17 10:12:31]

TBR jochen for includes and namespace changes in
chrome/browser/feedback
chrome/browser/ui/webui

[droger, 2015-09-17 10:12:40]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-09-17 10:12:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334173006/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334173006/70001

[commit-bot: I haz the power, 2015-09-17 10:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 10:21:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[droger, 2015-09-17 10:30:21]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-09-17 10:30:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334173006/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334173006/70001

[commit-bot: I haz the power, 2015-09-17 10:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-17 10:39:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[droger, 2015-09-17 10:41:32]

The CQ bit was checked by droger@chromium.org

[commit-bot: I haz the power, 2015-09-17 10:41:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1334173006/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1334173006/70001

[commit-bot: I haz the power, 2015-09-17 10:53:20]

Committed patchset #4 (id:70001)

[commit-bot: I haz the power, 2015-09-17 10:53:58]

Patchset 4 (id:??) landed as
https://crrev.com/5144c4343704453671333c412011678602bfa2aa
Cr-Commit-Position: refs/heads/master@{#349395}