[EnhancedBookmarks] Fix a crash on exiting while loading.

[Android] Fix enhanced bookmark crash on exiting while loading.

On phone, the close button on the top-right corner can be tapped while
the bookmark UI is loading, which led to a crash. So make the
exiting code doesn't depend on initialization.

BUG=531337
Committed: https://crrev.com/3d1eeb5b1e01f197658953ac28f854e3aaf46121
Cr-Commit-Position: refs/heads/master@{#348731}

[Kibeom Kim (inactive), 2015-09-14 18:40:22]

kkimlabs@chromium.org changed reviewers:
+ ianwen@chromium.org, newt@chromium.org

[newt (away), 2015-09-14 20:01:20]

Looks reasonable to me. Ian?

[Ian Wen, 2015-09-14 20:14:22]

One small thing. I remember we used to discuss that casting from Context to
Activity should be avoided in general.

https://codereview.chromium.org/1339783004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java
(right):

https://codereview.chromium.org/1339783004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java:87:
EnhancedBookmarkUtils.finishActivityOnPhone((Activity) getContext());
Can we avoid the cast here, and make finishActivityOnPhone takes a Context? You
are already doing type check inside of the function.

[Kibeom Kim (inactive), 2015-09-14 20:29:11]

https://codereview.chromium.org/1339783004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java
(right):

https://codereview.chromium.org/1339783004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkActionBar.java:87:
EnhancedBookmarkUtils.finishActivityOnPhone((Activity) getContext());
On 2015/09/14 20:14:22, Ian Wen wrote:
> Can we avoid the cast here, and make finishActivityOnPhone takes a Context?
You
> are already doing type check inside of the function.

Done.

[Ian Wen, 2015-09-14 20:41:13]

lgtm. Thanks!

[Kibeom Kim (inactive), 2015-09-14 20:41:40]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2015-09-14 20:42:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339783004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339783004/20001

[commit-bot: I haz the power, 2015-09-14 21:56:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-14 21:56:32]

Patchset 2 (id:??) landed as
https://crrev.com/3d1eeb5b1e01f197658953ac28f854e3aaf46121
Cr-Commit-Position: refs/heads/master@{#348731}

[commit-bot: I haz the power, 2015-09-23 12:37:43]

Patchset 2 (id:??) landed as
https://crrev.com/3d1eeb5b1e01f197658953ac28f854e3aaf46121
Cr-Commit-Position: refs/heads/master@{#348731}