Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4173)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java

Issue 1339783004: [EnhancedBookmarks] Fix a crash on exiting while loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Activity -> Context Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
index bf8bd74f4cf4c4f3ec569a8f297875460eef63cd..c08c46e13f74acd908c3d8f1e74735869da76104 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
@@ -422,7 +422,7 @@ public class EnhancedBookmarkManager implements EnhancedBookmarkDelegate {
RecordHistogram.recordEnumeratedHistogram("Stars.LaunchLocation", launchLocation,
LaunchLocation.COUNT);
EnhancedBookmarkUtils.openBookmark(mActivity, url);
- finishActivityOnPhone();
+ EnhancedBookmarkUtils.finishActivityOnPhone(mActivity);
}
}
@@ -439,14 +439,6 @@ public class EnhancedBookmarkManager implements EnhancedBookmarkDelegate {
}
@Override
- public void finishActivityOnPhone() {
- Activity activity = mActivity;
- if (activity instanceof EnhancedBookmarkActivity) {
- activity.finish();
- }
- }
-
- @Override
public void addUIObserver(EnhancedBookmarkUIObserver observer) {
mUIObservers.addObserver(observer);
}

Powered by Google App Engine
This is Rietveld 408576698