Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1339763005: MIPS64: Fix unittests (to not use invalid load representation). (Closed)

Created:
5 years, 3 months ago by paul.l...
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix unittests (to not use invalid load representation). Same as https://codereview.chromium.org/1340303002/ BUG= Committed: https://crrev.com/b4f9a95e6cd7e8d0a60c632282deaa984bcdc6d9 Cr-Commit-Position: refs/heads/master@{#30756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paul.l...
PTAL.
5 years, 3 months ago (2015-09-15 20:33:02 UTC) #2
akos.palfi.imgtec
LGTM
5 years, 3 months ago (2015-09-15 20:53:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339763005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339763005/1
5 years, 3 months ago (2015-09-15 20:56:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 21:28:19 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 21:28:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4f9a95e6cd7e8d0a60c632282deaa984bcdc6d9
Cr-Commit-Position: refs/heads/master@{#30756}

Powered by Google App Engine
This is Rietveld 408576698