content/browser/service_worker/service_worker_context_wrapper.cc - Issue 1339623002: Make registration.update() no longer force bypassing the HTTP cache (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_wrapper.cc

Issue 1339623002: Make registration.update() no longer force bypassing the HTTP cache (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_core.h ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_wrapper.cc

diff --git a/content/browser/service_worker/service_worker_context_wrapper.cc b/content/browser/service_worker/service_worker_context_wrapper.cc

index 76986889bd8fef1c2585991d30a8bbba3263e4ec..8e20182c5b1b66c326a515682ab570c6fd57771c 100644

--- a/content/browser/service_worker/service_worker_context_wrapper.cc

+++ b/content/browser/service_worker/service_worker_context_wrapper.cc

@@ -437,6 +437,11 @@ void ServiceWorkerContextWrapper::DidFindRegistrationForUpdate(

if (!context_core_)

return;

DCHECK(registration);

+ // TODO(jungkees): |force_bypass_cache| is set to true because the call stack

+ // is initiated by an update button on DevTools that expects the cache is

+ // bypassed. However, in order to provide options for callers to choose the

+ // cache bypass mode, plumb |force_bypass_cache| through to

+ // UpdateRegistration().

context_core_->UpdateServiceWorker(registration.get(),

true /* force_bypass_cache */);

}