Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: content/browser/service_worker/service_worker_dispatcher_host.cc

Issue 1339623002: Make registration.update() no longer force bypassing the HTTP cache (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index eb65e4e2be475a2b65c4a3f6dc2020cd8ad7bd13..8cbbd7dc73f190f2e01a9fc21f1084ddfac906c6 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -430,10 +430,8 @@ void ServiceWorkerDispatcherHost::OnUpdateServiceWorker(int thread_id,
return;
}
- // The spec says, "update() pings the server for an updated version of this
- // script without consulting caches", so set |force_bypass_cache| to true.
GetContext()->UpdateServiceWorker(
- registration, true, /* force_bypass_cache */
+ registration, false, /* force_bypass_cache */
provider_host, base::Bind(&ServiceWorkerDispatcherHost::UpdateComplete,
this, thread_id, provider_id, request_id));
}
« no previous file with comments | « content/browser/service_worker/service_worker_context_wrapper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698