Gamepad API support for chrome on android

content/browser/gamepad/gamepad_platform_data_fetcher_android.cc

Index: content/browser/gamepad/gamepad_platform_data_fetcher_android.cc
diff --git a/content/browser/gamepad/gamepad_platform_data_fetcher_android.cc b/content/browser/gamepad/gamepad_platform_data_fetcher_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d6effad331c4da2fba38d7027af68b6c25307b92
--- /dev/null
+++ b/content/browser/gamepad/gamepad_platform_data_fetcher_android.cc
@@ -0,0 +1,25 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/gamepad/gamepad_platform_data_fetcher_android.h"
+#include "third_party/WebKit/public/platform/WebGamepads.h"
+
+namespace content {
+
+GamepadPlatformDataFetcherAndroid::GamepadPlatformDataFetcherAndroid() {
+}
+
+GamepadPlatformDataFetcherAndroid::~GamepadPlatformDataFetcherAndroid() {
+}
+
+void GamepadPlatformDataFetcherAndroid::GetGamepadData(blink::WebGamepads* pads,
+                                                       bool) {
+  GamepadsReader::GetInstance()->GetGamepadData(pads);

[jdduke (slow), 2014/03/18 09:43:15]

Please have a look at my comments for gamepad_platform_data_fetcher_android.cc
from the other patch.  In short, because you're using a Java singleton, you
don't need a C++ singleton.  The native code should simply call into a static
method on the Java class, and the Java code should never need to *store* a
pointer to native code.  Any calls into Java from native should pass a pointer
to the |WebGamePads| object, which can be populated when calling back into a
(static) native method.  We should never store a reference to |pads|.

In that case, we should implement the logic here, and remove
|gamepad_read_impl.{cc,h}|.

[SaurabhK, 2014/03/18 12:45:30]

On 2014/03/18 09:43:15, jdduke wrote:

I had created a seperate class GamepadReader just for the JNI interaction.
I had seen other classes that make JNI call were placed at
content/browser/android/ like content_view_core.cc, therefore i kept the
structure like that.
Now i see that such files are at various directory locations so i will update
it.

+}
+
+void GamepadPlatformDataFetcherAndroid::PauseHint(bool isaccesspaused) {
+  GamepadsReader::GetInstance()->NotifyForGamepadsAccess(isaccesspaused);
+}
+
+}  // namespace content