Issue 13394014: Expand filter 0 to handle transparent drawBitmapRect paints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13394014: Expand filter 0 to handle transparent drawBitmapRect paints (Closed)

Created:
7 years, 8 months ago by robertphillips

Modified:
7 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

In the world of iteratively applied filters, we do see examples of filter-0 in which both the drawBitmapRect and saveLayer paints have transparency. This patch improves filter-0 so it can handle this case.

Patch Set 1 #

Patch Set 2 : Fix comments #

Total comments: 3

Patch Set 3 : Use SkMulDiv255Round #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -11 lines)			Patch
	M	tools/filtermain.cpp	View	1 2	3 chunks	+17 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm with a suggestion https://codereview.chromium.org/13394014/diff/2001/tools/filtermain.cpp File tools/filtermain.cpp (right): https://codereview.chromium.org/13394014/diff/2001/tools/filtermain.cpp#newcode97 tools/filtermain.cpp:97: int newA = (a0 * ...

7 years, 8 months ago (2013-04-02 14:53:27 UTC) #2

bsalomon

https://codereview.chromium.org/13394014/diff/2001/tools/filtermain.cpp File tools/filtermain.cpp (right): https://codereview.chromium.org/13394014/diff/2001/tools/filtermain.cpp#newcode97 tools/filtermain.cpp:97: int newA = (a0 * a1) / 255; On ...

7 years, 8 months ago (2013-04-02 14:55:52 UTC) #3

robertphillips

7 years, 8 months ago (2013-04-02 15:30:22 UTC) #4

Message was sent while issue was closed.

committed as r8486

https://codereview.chromium.org/13394014/diff/2001/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.chromium.org/13394014/diff/2001/tools/filtermain.cpp#newco...
tools/filtermain.cpp:97: int newA = (a0 * a1) / 255;
On 2013/04/02 14:55:53, bsalomon wrote:
> On 2013/04/02 14:53:27, bsalomon wrote:
> > It seems like there's probably some alpha mul macro that should be used
here.
> 
> SkMulDiv255Round?

Done.

Expand Messages | Collapse Messages